[webkit-changes] [WebKit/WebKit] 87061f: Mail content renders and flashes blank

[Richard Robinson]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 87061f83f12a164cbd8570dcbdb768380a30a2c7
      https://github.com/WebKit/WebKit/commit/87061f83f12a164cbd8570dcbdb768380a30a2c7
  Author: Richard Robinson <richard_robinson2 at apple.com>
  Date:   2024-02-15 (Thu, 15 Feb 2024)

  Changed paths:
    M Source/WebCore/PAL/pal/cocoa/DataDetectorsCoreSoftLink.h
    M Source/WebCore/PAL/pal/cocoa/DataDetectorsCoreSoftLink.mm
    M Source/WebCore/loader/FrameLoader.cpp

  Log Message:
  -----------
  Mail content renders and flashes blank
https://bugs.webkit.org/show_bug.cgi?id=269488
rdar://122998930

Reviewed by Tim Horton.

274699 at main introduced a new optional soft-linked function from DataDetectors. However, `canLoad`
was never called for the function before it was used, resulting in a crash.

Fix by making the soft-linked function no longer optional, since it doesn't actually even need to be.

Also fix a debug-only assert where an OptionSet was trying to be created from a raw value by using
the proper initializer.

* Source/WebCore/PAL/pal/cocoa/DataDetectorsCoreSoftLink.h:
* Source/WebCore/PAL/pal/cocoa/DataDetectorsCoreSoftLink.mm:
* Source/WebCore/loader/FrameLoader.cpp:
(WebCore::FrameLoader::checkLoadCompleteForThisFrame):

Canonical link: https://commits.webkit.org/274764@main