[webkit-changes] [WebKit/WebKit] 273218: [git-webkit] Prefer hash over identifier in relati...

Jonathan Bedard noreply at github.com
Thu Feb 15 11:23:19 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 273218f4e46a364786cbcbad9046a2632ca15c3a
      https://github.com/WebKit/WebKit/commit/273218f4e46a364786cbcbad9046a2632ca15c3a
  Author: Jonathan Bedard <jbedard at apple.com>
  Date:   2024-02-15 (Thu, 15 Feb 2024)

  Changed paths:
    M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/trace.py
    M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/trace_unittest.py

  Log Message:
  -----------
  [git-webkit] Prefer hash over identifier in relationships
https://bugs.webkit.org/show_bug.cgi?id=267889
rdar://121400016

Reviewed by Dewei Zhu.

Users can create identifiers from branches which aren't linear, so it's possible
that a branch identifier refers more than one commit in the history of the repository.
Since hashes are more stable, if a relationship uses both, prefer the hash.

* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/trace.py:
(Relationship.parse): Prefer hash commit reference when parsing relationships, even if the hash
reference is the secondary reference.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/trace_unittest.py:
(TestRelationship.test_cherry_pick):
(TestRelationship.test_revert):
(TestRelationship.test_follow_up):
(TestRelationship.test_double_revert):

Canonical link: https://commits.webkit.org/274747@main




More information about the webkit-changes mailing list