[webkit-changes] [WebKit/WebKit] f76100: [MSE] GPUConnection::sendSync should only ever be ...

[Jean-Yves Avenard]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f76100e64e9407be725c296707e69455cb3f8a18
      https://github.com/WebKit/WebKit/commit/f76100e64e9407be725c296707e69455cb3f8a18
  Author: Jean-Yves Avenard <jya at apple.com>
  Date:   2024-02-15 (Thu, 15 Feb 2024)

  Changed paths:
    M Source/WebKit/WebProcess/GPU/media/MediaSourcePrivateRemote.cpp
    M Source/WebKit/WebProcess/GPU/media/SourceBufferPrivateRemote.cpp
    M Source/WebKit/WebProcess/GPU/media/SourceBufferPrivateRemote.h

  Log Message:
  -----------
  [MSE] GPUConnection::sendSync should only ever be performed on the main thread
https://bugs.webkit.org/show_bug.cgi?id=269459
rdar://123005739

Reviewed by Youenn Fablet.

We run the sendSync operation through the main thread, as running them through
the MediaSourceRemote WorkQueue could trigger an assert in debug build or out
of order events otherwise.

The modified methods are already called on the main thread so we have no risk in
introducing a dead lock.

Covered by existing tests. No change of behaviour.

* Source/WebKit/WebProcess/GPU/media/MediaSourcePrivateRemote.cpp:
(WebKit::MediaSourcePrivateRemote::addSourceBuffer):
* Source/WebKit/WebProcess/GPU/media/SourceBufferPrivateRemote.cpp:
(WebKit::SourceBufferPrivateRemote::canSwitchToType):
(WebKit::SourceBufferPrivateRemote::evictCodedFrames):
(WebKit::SourceBufferPrivateRemote::minimumUpcomingPresentationTimeForTrackID):
* Source/WebKit/WebProcess/GPU/media/SourceBufferPrivateRemote.h:

Canonical link: https://commits.webkit.org/274735@main