[webkit-changes] [WebKit/WebKit] 155045: Silence static analyzer warning in generated isRea...

Chris Dumez noreply at github.com
Thu Feb 15 07:55:23 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 155045a81bee7039e48e7cc9e2584f919d687f5b
      https://github.com/WebKit/WebKit/commit/155045a81bee7039e48e7cc9e2584f919d687f5b
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2024-02-15 (Thu, 15 Feb 2024)

  Changed paths:
    M Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
    M Source/WebCore/bindings/scripts/test/JS/JSTestInterface.cpp
    M Source/WebCore/bindings/scripts/test/JS/JSTestLegacyFactoryFunction.cpp

  Log Message:
  -----------
  Silence static analyzer warning in generated isReachableFromOpaqueRoots() JS bindings functions
https://bugs.webkit.org/show_bug.cgi?id=269413

Reviewed by Darin Adler.

Silence static analyzer warning in generated isReachableFromOpaqueRoots() JS
bindings functions. We don't actually need to protected `wrapped` in the JS
bindings. Also, this function gets called off the main thread so it would
likely hit threading assertions in RefCounted if we tried.

* Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
* Source/WebCore/bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::JSTestInterfaceOwner::isReachableFromOpaqueRoots):
* Source/WebCore/bindings/scripts/test/JS/JSTestLegacyFactoryFunction.cpp:
(WebCore::JSTestLegacyFactoryFunctionOwner::isReachableFromOpaqueRoots):

Canonical link: https://commits.webkit.org/274732@main




More information about the webkit-changes mailing list