[webkit-changes] [WebKit/WebKit] 1b0f88: [WGSL] Validation of array element type is incorrect

Tadeu Zagallo noreply at github.com
Thu Feb 15 04:46:43 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1b0f8896c4d1d6503e3f560b9bad212aab613763
      https://github.com/WebKit/WebKit/commit/1b0f8896c4d1d6503e3f560b9bad212aab613763
  Author: Tadeu Zagallo <tzagallo at apple.com>
  Date:   2024-02-15 (Thu, 15 Feb 2024)

  Changed paths:
    M Source/WebGPU/WGSL/TypeCheck.cpp

  Log Message:
  -----------
  [WGSL] Validation of array element type is incorrect
https://bugs.webkit.org/show_bug.cgi?id=269386
rdar://122960489

Reviewed by Mike Wyrzykowski.

In 274617 at main I added a check that array elements must be constructible, but I missed
that this is only the case when constructing an array. For an array type (e.g. x: array<T>)
the element type must only have creation fixed footprint.

* Source/WebGPU/WGSL/TypeCheck.cpp:
(WGSL::TypeChecker::visit):

Canonical link: https://commits.webkit.org/274718@main




More information about the webkit-changes mailing list