[webkit-changes] [WebKit/WebKit] 46e0a7: Adopt even more smart pointer under WebCore/page/

Chris Dumez noreply at github.com
Wed Feb 14 13:09:38 PST 2024 

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 46e0a788746340ea0cabd5006bdac3e9f3c965cc
      https://github.com/WebKit/WebKit/commit/46e0a788746340ea0cabd5006bdac3e9f3c965cc
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
    M Source/WebCore/bindings/js/JSDOMWindowBase.cpp
    M Source/WebCore/css/CSSImportRule.cpp
    M Source/WebCore/css/CSSImportRule.h
    M Source/WebCore/page/CaptionUserPreferences.cpp
    M Source/WebCore/page/ContextMenuController.cpp
    M Source/WebCore/page/DeviceController.cpp
    M Source/WebCore/page/DragController.cpp
    M Source/WebCore/page/EventHandler.cpp
    M Source/WebCore/page/FocusController.cpp
    M Source/WebCore/page/FrameTree.cpp
    M Source/WebCore/page/FrameView.cpp
    M Source/WebCore/page/History.cpp
    M Source/WebCore/page/LocalDOMWindow.cpp
    M Source/WebCore/page/LocalDOMWindow.h
    M Source/WebCore/page/LocalFrameView.cpp
    M Source/WebCore/page/Location.cpp
    M Source/WebCore/page/Page.cpp
    M Source/WebCore/page/PageColorSampler.cpp
    M Source/WebCore/page/PageDebuggable.cpp
    M Source/WebCore/page/PageOverlay.cpp
    M Source/WebCore/page/PageOverlayController.cpp
    M Source/WebCore/page/PageOverlayController.h
    M Source/WebCore/page/PageSerializer.cpp
    M Source/WebCore/page/PerformanceLogging.cpp
    M Source/WebCore/page/PerformanceNavigation.cpp
    M Source/WebCore/page/PointerCaptureController.cpp
    M Source/WebCore/page/ResizeObservation.cpp
    M Source/WebCore/page/ResizeObservation.h
    M Source/WebCore/page/ResizeObserver.cpp
    M Source/WebCore/page/SettingsBase.cpp
    M Source/WebCore/page/VisualViewport.cpp
    M Source/WebCore/page/WorkerNavigator.cpp
    M Source/WebCore/page/mac/EventHandlerMac.mm
    M Source/WebCore/page/mac/ServicesOverlayController.mm
    M Source/WebCore/page/scrolling/AsyncScrollingCoordinator.cpp
    M Source/WebCore/page/scrolling/ScrollingCoordinator.cpp
    M Source/WebCore/page/scrolling/ScrollingCoordinator.h
    M Source/WebCore/page/scrolling/ScrollingStateFixedNode.cpp
    M Source/WebCore/page/scrolling/ThreadedScrollingCoordinator.cpp
    M Source/WebCore/page/scrolling/mac/ScrollingCoordinatorMac.mm
    M Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDOMWindow.cpp
    M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteScrollingCoordinator.mm

  Log Message:
  -----------
  Adopt even more smart pointer under WebCore/page/
https://bugs.webkit.org/show_bug.cgi?id=269267

Reviewed by Ryosuke Niwa.

Adopt even more smart pointer under WebCore/page/, as recommended by the static
analyzer.

* Source/WebCore/bindings/js/JSDOMWindowBase.cpp:
* Source/WebCore/css/CSSImportRule.cpp:
(WebCore::CSSImportRule::protectedStyleSheet const):
* Source/WebCore/css/CSSImportRule.h:
* Source/WebCore/page/CaptionUserPreferences.cpp:
(WebCore::CaptionUserPreferences::userPrefersTextDescriptions const):
* Source/WebCore/page/ContextMenuController.cpp:
(WebCore::ContextMenuController::contextMenuItemSelected):
* Source/WebCore/page/DeviceController.cpp:
(WebCore::DeviceController::dispatchDeviceEvent):
* Source/WebCore/page/DragController.cpp:
(WebCore::elementUnderMouse):
(WebCore::DragController::draggableElement const):
* Source/WebCore/page/EventHandler.cpp:
(WebCore::EventHandler::nodeWillBeRemoved):
(WebCore::EventHandler::handleMouseMoveEvent):
(WebCore::EventHandler::handleMouseReleaseEvent):
* Source/WebCore/page/FocusController.cpp:
(WebCore::FocusController::findFocusableElementAcrossFocusScope):
(WebCore::FocusController::findFocusableElementWithinScope):
(WebCore::FocusController::nextFocusableElementWithinScope):
(WebCore::FocusController::previousFocusableElementWithinScope):
(WebCore::FocusController::advanceFocusDirectionallyInContainer):
* Source/WebCore/page/FrameTree.cpp:
(WebCore::inScope):
(WebCore::FrameTree::find const):
* Source/WebCore/page/FrameView.cpp:
(WebCore::FrameView::invalidateRect):
(WebCore::FrameView::scrollableAreaBoundingBox const):
* Source/WebCore/page/History.cpp:
(WebCore::History::stateObjectAdded):
* Source/WebCore/page/LocalDOMWindow.cpp:
(WebCore::LocalDOMWindow::frameElement const):
(WebCore::LocalDOMWindow::protectedFrameElement const):
(WebCore::LocalDOMWindow::scrollTo const):
(WebCore::LocalDOMWindow::setLocation):
* Source/WebCore/page/LocalDOMWindow.h:
* Source/WebCore/page/LocalFrameView.cpp:
(WebCore::LocalFrameView::updateSnapOffsets):
(WebCore::shouldEnableSpeculativeTilingDuringLoading):
(WebCore::LocalFrameView::safeToPropagateScrollToParent const):
(WebCore::LocalFrameView::updateScrollCorner):
(WebCore::LocalFrameView::updateLayoutAndStyleIfNeededRecursive):
* Source/WebCore/page/Location.cpp:
(WebCore::Location::setLocation):
* Source/WebCore/page/Page.cpp:
(WebCore::Page::useDarkAppearance const):
(WebCore::Page::hasLocalDataForURL):
(WebCore::Page::configureLoggingChannel):
(WebCore::Page::removeInjectedUserStyleSheet):
(WebCore::Page::reloadExecutionContextsForOrigin const):
* Source/WebCore/page/PageColorSampler.cpp:
(WebCore::sampleColor):
* Source/WebCore/page/PageDebuggable.cpp:
(WebCore::PageDebuggable::name const):
* Source/WebCore/page/PageOverlay.cpp:
(WebCore::PageOverlay::viewToOverlayOffset const):
* Source/WebCore/page/PageOverlayController.cpp:
(WebCore::PageOverlayController::layerWithDocumentOverlays):
(WebCore::PageOverlayController::layerWithViewOverlays):
(WebCore::PageOverlayController::installPageOverlay):
(WebCore::PageOverlayController::uninstallPageOverlay):
(WebCore::PageOverlayController::setPageOverlayNeedsDisplay):
(WebCore::PageOverlayController::setPageOverlayOpacity):
(WebCore::PageOverlayController::clearPageOverlay):
(WebCore::PageOverlayController::layerForOverlay const):
(WebCore::PageOverlayController::didChangeViewSize):
(WebCore::PageOverlayController::didChangeDocumentSize):
(WebCore::PageOverlayController::didChangeSettings):
(WebCore::PageOverlayController::didChangeDeviceScaleFactor):
(WebCore::PageOverlayController::didScrollFrame):
(WebCore::PageOverlayController::paintContents):
(WebCore::PageOverlayController::didChangeOverlayFrame):
(WebCore::PageOverlayController::didChangeOverlayBackgroundColor):
* Source/WebCore/page/PageOverlayController.h:
* Source/WebCore/page/PageSerializer.cpp:
(WebCore::PageSerializer::serializeFrame):
(WebCore::PageSerializer::serializeCSSStyleSheet):
(WebCore::PageSerializer::retrieveResourcesForRule):
* Source/WebCore/page/PerformanceLogging.cpp:
(WebCore::PerformanceLogging::memoryUsageStatistics):
* Source/WebCore/page/PerformanceNavigation.cpp:
(WebCore::PerformanceNavigation::redirectCount const):
* Source/WebCore/page/PointerCaptureController.cpp:
(WebCore::PointerCaptureController::hasPointerCapture):
(WebCore::PointerCaptureController::cancelPointer):
* Source/WebCore/page/ResizeObservation.cpp:
(WebCore::ResizeObservation::protectedTarget const):
* Source/WebCore/page/ResizeObservation.h:
* Source/WebCore/page/ResizeObserver.cpp:
(WebCore::ResizeObserver::gatherObservations):
(WebCore::ResizeObserver::deliverObservations):
(WebCore::ResizeObserver::removeAllTargets):
* Source/WebCore/page/SettingsBase.cpp:
(WebCore::SettingsBase::mediaTypeOverrideChanged):
* Source/WebCore/page/VisualViewport.cpp:
(WebCore::VisualViewport::scriptExecutionContext const):
* Source/WebCore/page/WorkerNavigator.cpp:
(WebCore::WorkerNavigator::gpu):
* Source/WebCore/page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::passSubframeEventToSubframe):
* Source/WebCore/page/mac/ServicesOverlayController.mm:
(WebCore::ServicesOverlayController::remainingTimeUntilHighlightShouldBeShown const):
(WebCore::ServicesOverlayController::buildPhoneNumberHighlights):
(WebCore::ServicesOverlayController::buildSelectionHighlight):
(WebCore::ServicesOverlayController::createOverlayIfNeeded):
(WebCore::ServicesOverlayController::telephoneNumberRangesForFocusedFrame):
(WebCore::ServicesOverlayController::handleClick):
* Source/WebCore/page/scrolling/AsyncScrollingCoordinator.cpp:
(WebCore::AsyncScrollingCoordinator::hysterisisTimerFired):
(WebCore::AsyncScrollingCoordinator::handleWheelEventPhase):
(WebCore::AsyncScrollingCoordinator::frameViewLayoutUpdated):
(WebCore::AsyncScrollingCoordinator::frameViewVisualViewportChanged):
(WebCore::AsyncScrollingCoordinator::frameViewWillBeDetached):
(WebCore::AsyncScrollingCoordinator::updateIsMonitoringWheelEventsForFrameView):
(WebCore::AsyncScrollingCoordinator::frameViewEventTrackingRegionsChanged):
(WebCore::AsyncScrollingCoordinator::frameViewRootLayerDidChange):
(WebCore::AsyncScrollingCoordinator::requestStartKeyboardScrollAnimation):
(WebCore::AsyncScrollingCoordinator::requestStopKeyboardScrollAnimation):
(WebCore::AsyncScrollingCoordinator::requestScrollToPosition):
(WebCore::AsyncScrollingCoordinator::stopAnimatedScroll):
(WebCore::AsyncScrollingCoordinator::setMouseIsOverScrollbar):
(WebCore::AsyncScrollingCoordinator::setMouseIsOverContentArea):
(WebCore::AsyncScrollingCoordinator::setMouseMovedInContentArea):
(WebCore::AsyncScrollingCoordinator::setScrollbarEnabled):
(WebCore::AsyncScrollingCoordinator::scheduleRenderingUpdate):
(WebCore::AsyncScrollingCoordinator::frameViewForScrollingNode const):
(WebCore::AsyncScrollingCoordinator::animatedScrollWillStartForNode):
(WebCore::AsyncScrollingCoordinator::animatedScrollDidEndForNode):
(WebCore::AsyncScrollingCoordinator::wheelEventScrollWillStartForNode):
(WebCore::AsyncScrollingCoordinator::wheelEventScrollDidEndForNode):
(WebCore::AsyncScrollingCoordinator::updateScrollPositionAfterAsyncScroll):
(WebCore::AsyncScrollingCoordinator::reconcileScrollingState):
(WebCore::AsyncScrollingCoordinator::scrollableAreaScrollbarLayerDidChange):
(WebCore::AsyncScrollingCoordinator::setNodeLayers):
(WebCore::AsyncScrollingCoordinator::setFrameScrollingNodeState):
(WebCore::AsyncScrollingCoordinator::setScrollingNodeScrollableAreaGeometry):
(WebCore::AsyncScrollingCoordinator::setViewportConstraintedNodeConstraints):
(WebCore::AsyncScrollingCoordinator::setPositionedNodeConstraints):
(WebCore::AsyncScrollingCoordinator::setRelatedOverflowScrollingNodes):
(WebCore::AsyncScrollingCoordinator::setSynchronousScrollingReasons):
(WebCore::AsyncScrollingCoordinator::synchronousScrollingReasons const):
(WebCore::AsyncScrollingCoordinator::scrollableContainerNodeID const):
(WebCore::AsyncScrollingCoordinator::setActiveScrollSnapIndices):
(WebCore::AsyncScrollingCoordinator::updateScrollSnapPropertiesWithFrameView):
(WebCore::AsyncScrollingCoordinator::reportExposedUnfilledArea):
(WebCore::AsyncScrollingCoordinator::reportSynchronousScrollingReasonsChanged):
(WebCore::AsyncScrollingCoordinator::scrollAnimatorEnabled const):
* Source/WebCore/page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::protectedPage const):
* Source/WebCore/page/scrolling/ScrollingCoordinator.h:
(WebCore::ScrollingCoordinator::page const):
* Source/WebCore/page/scrolling/ScrollingStateFixedNode.cpp:
(WebCore::ScrollingStateFixedNode::reconcileLayerPositionForViewportRect):
* Source/WebCore/page/scrolling/ThreadedScrollingCoordinator.cpp:
(WebCore::ThreadedScrollingCoordinator::handleWheelEventForScrolling):
(WebCore::ThreadedScrollingCoordinator::willStartRenderingUpdate):
* Source/WebCore/page/scrolling/mac/ScrollingCoordinatorMac.mm:
(WebCore::ScrollingCoordinatorMac::updateTiledScrollingIndicator):
* Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteScrollingCoordinator.mm:
(WebKit::RemoteScrollingCoordinator::receivedWheelEventWithPhases):
(WebKit::RemoteScrollingCoordinator::startDeferringScrollingTestCompletionForNode):
(WebKit::RemoteScrollingCoordinator::stopDeferringScrollingTestCompletionForNode):

Canonical link: https://commits.webkit.org/274652@main

More information about the webkit-changes mailing list