[webkit-changes] [WebKit/WebKit] 36543a: run-javascriptcore-tests: Allow a cap on the effec...

aoikonomopoulos noreply at github.com
Wed Feb 14 02:57:14 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 36543ae6e0e96340bd5071a9e3c6018fd1b6549e
      https://github.com/WebKit/WebKit/commit/36543ae6e0e96340bd5071a9e3c6018fd1b6549e
  Author: Angelos Oikonomopoulos <angelos at igalia.com>
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
    M Tools/Scripts/run-javascriptcore-tests
    M Tools/Scripts/run-jsc-stress-tests

  Log Message:
  -----------
  run-javascriptcore-tests: Allow a cap on the effective timeout
https://bugs.webkit.org/show_bug.cgi?id=269318

Reviewed by Justin Michaud.

run-jsc-stress-tests scales up JSC_timeout by the number of cores. On
high core count machines, this would push the value above the 1200
seconds after which buildbot will kill the running command if it hasn't
seen any output. This means that when a single JSC stress test would
hang, the whole test run would ends up wasted and the user'd only get a
cryptic

    command timed out: 1200 seconds without output running

message that gives no information as to which test got stuck.

Add a --max-timeout parameter, which the CI environment can use to cap
the effective per-stress-test timeout to something less than the
buildbot timeout.

* Tools/Scripts/run-javascriptcore-tests:
(runJSCStressTests):
* Tools/Scripts/run-jsc-stress-tests:

Canonical link: https://commits.webkit.org/274620@main




More information about the webkit-changes mailing list