[webkit-changes] [WebKit/WebKit] a28287: [WGSL] Stack overflow when parsing coreLHSExpression

Tadeu Zagallo noreply at github.com
Wed Feb 14 02:40:51 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a28287972916cdb8091cb16e74b47d87fe5cf7a1
      https://github.com/WebKit/WebKit/commit/a28287972916cdb8091cb16e74b47d87fe5cf7a1
  Author: Tadeu Zagallo <tzagallo at apple.com>
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
    M Source/WebGPU/WGSL/Parser.cpp

  Log Message:
  -----------
  [WGSL] Stack overflow when parsing coreLHSExpression
https://bugs.webkit.org/show_bug.cgi?id=269306
rdar://122293634

Reviewed by Mike Wyrzykowski.

We have a check for maximum recursion depth in parseLHSExpression, but for some reason
we only checked when parsing a unary expression, so we could still overflow when the
lhs expression was a "coreLHSExpression".

* Source/WebGPU/WGSL/Parser.cpp:
(WGSL::Parser<Lexer>::parseLHSExpression):

Canonical link: https://commits.webkit.org/274616@main




More information about the webkit-changes mailing list