[webkit-changes] [WebKit/WebKit] 518c5d: REGRESSION(273906 at main): [GStreamer] webrtc/receiv...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 518c5dcd9b48dc4c31ad4677f957d0d9b8e20773
      https://github.com/WebKit/WebKit/commit/518c5dcd9b48dc4c31ad4677f957d0d9b8e20773
  Author: Philippe Normand <philn at igalia.com>
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
    M LayoutTests/platform/glib/TestExpectations
    M Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingMediaSourceGStreamer.cpp
    M Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingMediaSourceGStreamer.h

  Log Message:
  -----------
  REGRESSION(273906 at main): [GStreamer] webrtc/receiver-track-should-stay-live-even-if-receiver-is-inactive.html is flaky crash
https://bugs.webkit.org/show_bug.cgi?id=268906

Reviewed by Xabier Rodriguez-Calvar.

Flaky crashes were triggered when the codecPreferencesChanged() was called while the blocking pad
probe was still active. We now prevent re-entry when this is the case.

* LayoutTests/platform/glib/TestExpectations:
* Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingMediaSourceGStreamer.cpp:
(WebCore::RealtimeOutgoingMediaSourceGStreamer::start):
(WebCore::RealtimeOutgoingMediaSourceGStreamer::setSinkPad):
(WebCore::RealtimeOutgoingMediaSourceGStreamer::teardown):
(WebCore::RealtimeOutgoingMediaSourceGStreamer::codecPreferencesChanged):
* Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingMediaSourceGStreamer.h:

Canonical link: https://commits.webkit.org/274614@main