[webkit-changes] [WebKit/WebKit] 77ac33: UnifiedPDF: Add instructions and icon to unlock UI

[Tim Horton]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 77ac3375317c66a06fc0cd93c216f5295d73c4ab
      https://github.com/WebKit/WebKit/commit/77ac3375317c66a06fc0cd93c216f5295d73c4ab
  Author: Tim Horton <thorton at apple.com>
  Date:   2024-02-13 (Tue, 13 Feb 2024)

  Changed paths:
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebCore/en.lproj/Localizable.strings
    M Source/WebCore/platform/LocalizedStrings.cpp
    M Source/WebCore/platform/LocalizedStrings.h
    M Source/WebKit/SourcesCocoa.txt
    M Source/WebKit/WebKit.xcodeproj/project.pbxproj
    M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginAnnotation.mm
    M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h
    M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginPasswordField.h
    M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginPasswordField.mm
    A Source/WebKit/WebProcess/Plugins/PDF/PDFPluginPasswordForm.h
    A Source/WebKit/WebProcess/Plugins/PDF/PDFPluginPasswordForm.mm
    M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.h
    M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm

  Log Message:
  -----------
  UnifiedPDF: Add instructions and icon to unlock UI
https://bugs.webkit.org/show_bug.cgi?id=269345
rdar://122929864

Reviewed by Simon Fraser.

* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
Export XMLNSNames.h.

* Source/WebCore/en.lproj/Localizable.strings:
* Source/WebCore/platform/LocalizedStrings.cpp:
(WebCore::pdfPasswordFormTitle):
(WebCore::pdfPasswordFormSubtitle):
(WebCore::pdfPasswordFormInvalidPasswordSubtitle):
* Source/WebCore/platform/LocalizedStrings.h:
Add some strings.

* Source/WebKit/SourcesCocoa.txt:
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Source/WebKit/WebProcess/Plugins/PDF/PDFPluginAnnotation.mm:
(WebKit::PDFPluginAnnotation::attach):
If a PDFPluginAnnotation subclass puts a class on its element, don't overwrite it.

* Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h:
Update our inline style and add some new rules for the password form.

* Source/WebKit/WebProcess/Plugins/PDF/PDFPluginPasswordField.h:
(WebKit::PDFPluginPasswordField::PDFPluginPasswordField):
* Source/WebKit/WebProcess/Plugins/PDF/PDFPluginPasswordField.mm:
(WebKit::PDFPluginPasswordField::resetField):
Add a method to clear the field.

* Source/WebKit/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.h:
* Source/WebKit/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:
(WebKit::PDFPluginTextAnnotation::createAnnotationElement):
(WebKit::PDFPluginTextAnnotation::setValue):
Factor out setValue (and implement it in a simpler way).

* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h:
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::createPasswordEntryForm):
Install the form (UnifiedPDF only) ahead of the field (used by both plugins).

(WebKit::UnifiedPDFPlugin::attemptToUnlockPDF):
If the unlock fails, clear the field and change the form's instructions to note that.

* Source/WebKit/WebProcess/Plugins/PDF/PDFPluginPasswordForm.h: Added.
* Source/WebKit/WebProcess/Plugins/PDF/PDFPluginPasswordForm.mm: Added.
Add PDFPluginPasswordForm, which vends the UI above the password entry field
for UnifiedPDF.

Canonical link: https://commits.webkit.org/274609@main