[webkit-changes] [WebKit/WebKit] fc0a2c: ASSERTION FAILED: softWrapOpportunityIndex > 1 || ...

Alan Baradlay noreply at github.com
Tue Feb 13 19:30:25 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fc0a2c0135c75123fde7959994bb8094cb08c074
      https://github.com/WebKit/WebKit/commit/fc0a2c0135c75123fde7959994bb8094cb08c074
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-02-13 (Tue, 13 Feb 2024)

  Changed paths:
    A LayoutTests/fast/inline/float-and-out-of-flow-assert-expected.txt
    A LayoutTests/fast/inline/float-and-out-of-flow-assert.html
    M Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp

  Log Message:
  -----------
  ASSERTION FAILED: softWrapOpportunityIndex > 1 || inlineItemList[softWrapOpportunityIndex].isFloat()
https://bugs.webkit.org/show_bug.cgi?id=268967
<rdar://problem/122548442>

Reviewed by Antti Koivisto.

Calling hasTrailingSoftWrapOpportunity recursively does not play well with this ASSERT (softWrapOpportunityIndex).
- keep float assertion
- use iterative approach

* LayoutTests/fast/inline/float-and-out-of-flow-assert-expected.txt: Added.
* LayoutTests/fast/inline/float-and-out-of-flow-assert.html: Added.
* Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:
(WebCore::Layout::hasTrailingSoftWrapOpportunity):

Canonical link: https://commits.webkit.org/274600@main




More information about the webkit-changes mailing list