[webkit-changes] [WebKit/WebKit] 2db678: REGRESSION(274325 at main): didFindString is always f...

[Charlie Wolfe]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2db6785ed8fff72f4235a477450e2efbc555197d
      https://github.com/WebKit/WebKit/commit/2db6785ed8fff72f4235a477450e2efbc555197d
  Author: Charlie Wolfe <charliew at apple.com>
  Date:   2024-02-13 (Tue, 13 Feb 2024)

  Changed paths:
    M Source/WebKit/WebProcess/WebPage/FindController.cpp

  Log Message:
  -----------
  REGRESSION(274325 at main): didFindString is always false when searching in PDFs
rdar://122901465
https://bugs.webkit.org/show_bug.cgi?id=269310

Reviewed by Sammy Gill.

After 274325 at main, API::FindClient::didFindString() is called in the completion handler of the final
FindString message if a match was found inside a frame. For PDFs, this frame ID was never set, so
didFindString would never be called. For now, if a match is found in a PDF, mark the main frame as the
frame containing the match.

* Source/WebKit/WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::findString):

Canonical link: https://commits.webkit.org/274585@main