[webkit-changes] [WebKit/WebKit] d7c429: [UnifiedPDF] PDFPluginBase should forward Spotligh...

[Abrar Rahman Protyasha]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d7c4292b37659eeb541526ced9c8db8ed054042d
      https://github.com/WebKit/WebKit/commit/d7c4292b37659eeb541526ced9c8db8ed054042d
  Author: Abrar Rahman Protyasha <a_protyasha at apple.com>
  Date:   2024-02-13 (Tue, 13 Feb 2024)

  Changed paths:
    M Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.h
    M Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm
    M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h
    M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.mm

  Log Message:
  -----------
  [UnifiedPDF] PDFPluginBase should forward Spotlight/Web search queries to the web page
https://bugs.webkit.org/show_bug.cgi?id=269316
rdar://122906584

Reviewed by Simon Fraser.

In preparation of Spotlight/Web search context menu items, this patch
moves the (implementation-agnostic) logic to forward search queries into
PDFPluginBase.

We are also a little more defensive in forwarding our queries -
particularly for Spotlight search - to prevent bugs like rdar://40300615.

* Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.h:
* Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:
(-[WKPDFLayerControllerDelegate performWebSearch:]):
(-[WKPDFLayerControllerDelegate performSpotlightSearch:]):
(WebKit::PDFPlugin::scaleFactor const):
(WebKit::PDFPlugin::performWebSearch): Deleted.
(WebKit::PDFPlugin::performSpotlightSearch): Deleted.
* Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h:
* Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.mm:
(WebKit::PDFPluginBase::performSpotlightSearch):
(WebKit::PDFPluginBase::performWebSearch):

Canonical link: https://commits.webkit.org/274583@main