[webkit-changes] [WebKit/WebKit] 5821ff: Don't make HTMLMediaElement use WeakPtrImplWithEve...

[Jean-Yves Avenard]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5821ffe0a29ba84e770956937256eefb80c3f4b6
      https://github.com/WebKit/WebKit/commit/5821ffe0a29ba84e770956937256eefb80c3f4b6
  Author: Jean-Yves Avenard <jya at apple.com>
  Date:   2024-02-13 (Tue, 13 Feb 2024)

  Changed paths:
    M Source/WebCore/Modules/WebGPU/GPUDevice.cpp
    M Source/WebCore/Modules/WebGPU/GPUDevice.h
    M Source/WebCore/Modules/encryptedmedia/legacy/WebKitMediaKeys.h
    M Source/WebCore/Modules/mediacontrols/MediaControlsHost.h
    M Source/WebCore/Modules/mediasource/MediaSource.h
    M Source/WebCore/Modules/remoteplayback/RemotePlayback.h
    M Source/WebCore/dom/Document.h
    M Source/WebCore/html/HTMLMediaElement.cpp
    M Source/WebCore/html/HTMLMediaElement.h
    M Source/WebCore/html/MediaDocument.cpp
    M Source/WebCore/html/shadow/MediaControlTextTrackContainerElement.h
    M Source/WebCore/inspector/agents/InspectorDOMAgent.h
    M Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.h
    M Source/WebKit/WebProcess/cocoa/PlaybackSessionManager.h
    M Source/WebKit/WebProcess/cocoa/TextTrackRepresentationCocoa.h
    M Source/WebKit/WebProcess/cocoa/VideoPresentationManager.h

  Log Message:
  -----------
  Don't make HTMLMediaElement use WeakPtrImplWithEventTargetData
https://bugs.webkit.org/show_bug.cgi?id=269282
rdar://122859494

Reviewed by Chris Dumez.

A WeakPtr<HTMLMediaElement> needs do be copyable across threads,
which the WeakPtrImplWithEventTargetData argument prevents.

We remove it.

No change in observable behaviour.

* Source/WebCore/Modules/WebGPU/GPUDevice.cpp:
* Source/WebCore/Modules/WebGPU/GPUDevice.h:
* Source/WebCore/Modules/encryptedmedia/legacy/WebKitMediaKeys.h:
* Source/WebCore/Modules/mediacontrols/MediaControlsHost.h:
* Source/WebCore/Modules/mediasource/MediaSource.h:
* Source/WebCore/Modules/remoteplayback/RemotePlayback.h:
* Source/WebCore/dom/Document.h:
* Source/WebCore/html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::allMediaElements):
(WebCore::HTMLMediaElement::updateActiveTextTrackCues):
(WebCore::HTMLMediaElement::progressEventTimerFired):
* Source/WebCore/html/HTMLMediaElement.h:
* Source/WebCore/html/MediaDocument.cpp:
* Source/WebCore/html/shadow/MediaControlTextTrackContainerElement.h:
* Source/WebCore/inspector/agents/InspectorDOMAgent.h:
* Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.h:
* Source/WebKit/WebProcess/cocoa/PlaybackSessionManager.h:
* Source/WebKit/WebProcess/cocoa/TextTrackRepresentationCocoa.h:
* Source/WebKit/WebProcess/cocoa/VideoPresentationManager.h:

Canonical link: https://commits.webkit.org/274570@main