[webkit-changes] [WebKit/WebKit] 7f0ea2: [threaded-animation-resolution] webanimations/seek...

Antoine Quint noreply at github.com
Tue Feb 13 09:16:12 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7f0ea2560ba1232e6f32da91332921f655652296
      https://github.com/WebKit/WebKit/commit/7f0ea2560ba1232e6f32da91332921f655652296
  Author: Antoine Quint <graouts at webkit.org>
  Date:   2024-02-13 (Tue, 13 Feb 2024)

  Changed paths:
    M Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeNode.mm
    M Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteLayerTreeEventDispatcher.cpp

  Log Message:
  -----------
  [threaded-animation-resolution] webanimations/seeking-by-changing-delay-accelerated.html is a failure
https://bugs.webkit.org/show_bug.cgi?id=269279
rdar://122856750

Reviewed by Simon Fraser.

On macOS, the `RemoteAcceleratedStack` ownership is transferred from the target `RemoteLayerTreeNode` to the
`RemoteLayerTreeEventDispatcher`. So when we set new effects, including the case where we remove them
altogether, we cannot rely on `RemoteLayerTreeNode::m_effectStack` being set because the effect stack would
have been transferred. So we need to call `animationsWereRemovedFromNode()` on the host through to the dispatcher
and call `RemoteAcceleratedStack::clear()` from there.

* Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeNode.mm:
(WebKit::RemoteLayerTreeNode::setAcceleratedEffectsAndBaseValues):
* Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteLayerTreeEventDispatcher.cpp:
(WebKit::RemoteLayerTreeEventDispatcher::animationsWereRemovedFromNode):

Canonical link: https://commits.webkit.org/274549@main




More information about the webkit-changes mailing list