[webkit-changes] [WebKit/WebKit] 0e6f02: [Skia] Building with USE_SKIA=ON still uses Cairo ...

Carlos Garcia Campos noreply at github.com
Tue Feb 13 05:44:46 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0e6f0245ab8d06d0bfa36cb19d3054d86b8ed798
      https://github.com/WebKit/WebKit/commit/0e6f0245ab8d06d0bfa36cb19d3054d86b8ed798
  Author: Carlos Garcia Campos <cgarcia at igalia.com>
  Date:   2024-02-13 (Tue, 13 Feb 2024)

  Changed paths:
    M Source/ThirdParty/skia/CMakeLists.txt
    M Tools/ImageDiff/Cairo.cmake
    M Tools/ImageDiff/PlatformImage.h
    M Tools/ImageDiff/PlatformWPE.cmake
    A Tools/ImageDiff/Skia.cmake
    A Tools/ImageDiff/skia/PlatformImageSkia.cpp

  Log Message:
  -----------
  [Skia] Building with USE_SKIA=ON still uses Cairo for ImageDiff
https://bugs.webkit.org/show_bug.cgi?id=269190

Reviewed by Alejandro G. Castro and Nikolas Zimmermann.

Add ImageDiff implementation for Skia.

* Source/ThirdParty/skia/CMakeLists.txt:
* Tools/ImageDiff/Cairo.cmake:
* Tools/ImageDiff/PlatformImage.h:
* Tools/ImageDiff/PlatformWPE.cmake:
* Tools/ImageDiff/Skia.cmake: Added.
* Tools/ImageDiff/skia/PlatformImageSkia.cpp: Added.
(ImageDiff::createFromStream):
(ImageDiff::PlatformImage::createFromFile):
(ImageDiff::PlatformImage::createFromStdin):
(ImageDiff::PlatformImage::createFromDiffData):
(ImageDiff::PlatformImage::PlatformImage):
(ImageDiff::PlatformImage::~PlatformImage):
(ImageDiff::PlatformImage::width const):
(ImageDiff::PlatformImage::height const):
(ImageDiff::PlatformImage::rowBytes const):
(ImageDiff::PlatformImage::hasAlpha const):
(ImageDiff::PlatformImage::pixels const):
(ImageDiff::PlatformImage::writeAsPNGToStdout):

Canonical link: https://commits.webkit.org/274544@main




More information about the webkit-changes mailing list