[webkit-changes] [WebKit/WebKit] 272b9b: Move VKCImageAnalysis deserialization away from ot...

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 272b9bed22c24464ce9e3862066291558badba97
      https://github.com/WebKit/WebKit/commit/272b9bed22c24464ce9e3862066291558badba97
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2024-02-12 (Mon, 12 Feb 2024)

  Changed paths:
    M Source/WebCore/platform/TextRecognitionResult.h
    M Source/WebCore/platform/cocoa/TextRecognitionResultCocoa.mm
    M Source/WebCore/testing/Internals.cpp
    M Source/WebKit/Platform/cocoa/ImageAnalysisUtilities.mm
    M Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.mm
    M Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.mm
    M Source/WebKit/Shared/TextRecognitionResult.serialization.in
    M Source/WebKit/Shared/WebCoreArgumentCoders.h

  Log Message:
  -----------
  Move VKCImageAnalysis deserialization away from other NSObject deserializers
https://bugs.webkit.org/show_bug.cgi?id=269230
rdar://122825380

Reviewed by Wenson Hsieh.

It is currently the only ObjC object that is deserialized from IPC without
_enableStrictSecureDecodingMode, which is less urgent because it is only sent
from the trusted UI process to the untrusted web content process.  This PR just
moves that logic away from the rest of the IPC logic and adds a
release assertion to make sure we don't introduce a security issue in the future.

* Source/WebCore/platform/TextRecognitionResult.h:
* Source/WebCore/platform/cocoa/TextRecognitionResultCocoa.mm:
(WebCore::TextRecognitionResult::encodeVKCImageAnalysis):
(WebCore::TextRecognitionResult::decodeVKCImageAnalysis):
(WebCore::stringForRange):
* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::installImageOverlay):
* Source/WebKit/Platform/cocoa/ImageAnalysisUtilities.mm:
(WebKit::makeTextRecognitionResult):
* Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.mm:
(IPC::shouldEnableStrictMode):
* Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.mm:
(IPC::getClass<VKCImageAnalysis>): Deleted.
(IPC::ArgumentCoder<RetainPtr<VKCImageAnalysis>>::encode): Deleted.
(IPC::ArgumentCoder<RetainPtr<VKCImageAnalysis>>::decode): Deleted.
* Source/WebKit/Shared/TextRecognitionResult.serialization.in:
* Source/WebKit/Shared/WebCoreArgumentCoders.h:

Canonical link: https://commits.webkit.org/274495@main