[webkit-changes] [WebKit/WebKit] cac77a: Adopt more smart pointers under WebCore/page/

Chris Dumez noreply at github.com
Mon Feb 12 13:53:31 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cac77a010b989177ff66d391dacea5563cd4f48f
      https://github.com/WebKit/WebKit/commit/cac77a010b989177ff66d391dacea5563cd4f48f
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2024-02-12 (Mon, 12 Feb 2024)

  Changed paths:
    M Source/WebCore/bindings/js/JSWindowProxy.cpp
    M Source/WebCore/bindings/js/JSWindowProxy.h
    M Source/WebCore/dom/Node.cpp
    M Source/WebCore/dom/Node.h
    M Source/WebCore/html/HTMLFrameOwnerElement.cpp
    M Source/WebCore/html/HTMLFrameOwnerElement.h
    M Source/WebCore/inspector/agents/page/PageRuntimeAgent.cpp
    M Source/WebCore/page/DOMSelection.cpp
    M Source/WebCore/page/EventHandler.cpp
    M Source/WebCore/page/FocusController.cpp
    M Source/WebCore/page/FocusController.h
    M Source/WebCore/page/LocalDOMWindow.cpp
    M Source/WebCore/page/LocalFrame.cpp
    M Source/WebCore/page/LocalFrameView.cpp
    M Source/WebCore/page/LocalFrameViewLayoutContext.cpp
    M Source/WebCore/page/LocalFrameViewLayoutContext.h
    M Source/WebCore/page/Location.cpp
    M Source/WebCore/page/MouseEventWithHitTestResults.h
    M Source/WebCore/page/Navigator.cpp
    M Source/WebCore/page/Page.cpp
    M Source/WebCore/page/Page.h
    M Source/WebCore/page/PageConsoleClient.cpp
    M Source/WebCore/page/PageConsoleClient.h
    M Source/WebCore/page/PageOverlayController.cpp
    M Source/WebCore/page/PageOverlayController.h
    M Source/WebCore/page/PerformanceMonitor.cpp
    M Source/WebCore/page/PerformanceMonitor.h
    M Source/WebCore/page/PointerLockController.cpp
    M Source/WebCore/page/Quirks.cpp
    M Source/WebCore/page/Quirks.h
    M Source/WebCore/page/ResourceUsageOverlay.cpp
    M Source/WebCore/page/Screen.cpp
    M Source/WebCore/page/SpatialNavigation.cpp
    M Source/WebCore/page/SpatialNavigation.h
    M Source/WebCore/page/WebKitNamespace.cpp
    M Source/WebCore/page/cocoa/WebTextIndicatorLayer.mm
    M Source/WebCore/page/mac/EventHandlerMac.mm
    M Source/WebCore/page/mac/ServicesOverlayController.h
    M Source/WebCore/page/mac/ServicesOverlayController.mm
    M Source/WebCore/rendering/HitTestResult.cpp
    M Source/WebCore/rendering/HitTestResult.h
    M Source/WebCore/rendering/RenderWidget.h

  Log Message:
  -----------
  Adopt more smart pointers under WebCore/page/
https://bugs.webkit.org/show_bug.cgi?id=269209

Reviewed by Brent Fulgham.

* Source/WebCore/bindings/js/JSWindowProxy.cpp:
(WebCore::JSWindowProxy::protectedWorld):
* Source/WebCore/bindings/js/JSWindowProxy.h:
* Source/WebCore/dom/Node.cpp:
(WebCore::Node::protectedContainingShadowRoot const):
(WebCore::Node::checkedRenderer const):
* Source/WebCore/dom/Node.h:
* Source/WebCore/html/HTMLFrameOwnerElement.cpp:
(WebCore::HTMLFrameOwnerElement::~HTMLFrameOwnerElement):
(WebCore::HTMLFrameOwnerElement::protectedContentFrame const):
* Source/WebCore/html/HTMLFrameOwnerElement.h:
* Source/WebCore/inspector/agents/page/PageRuntimeAgent.cpp:
(WebCore::PageRuntimeAgent::PageRuntimeAgent):
(WebCore::PageRuntimeAgent::reportExecutionContextCreation):
* Source/WebCore/page/DOMSelection.cpp:
(WebCore::DOMSelection::getComposedRanges):
* Source/WebCore/page/EventHandler.cpp:
(WebCore::EventHandler::updateSelectionForMouseDrag):
(WebCore::EventHandler::hitTestResultAtPoint const):
(WebCore::EventHandler::performDragAndDrop):
(WebCore::EventHandler::dispatchMouseEvent):
(WebCore::EventHandler::sendContextMenuEvent):
(WebCore::EventHandler::dispatchEventToDragSourceElement):
(WebCore::EventHandler::handleDrag):
(WebCore::EventHandler::keyboardScrollRecursively):
* Source/WebCore/page/FocusController.cpp:
(WebCore::FocusController::setFocusedFrame):
(WebCore::FocusController::focusedOrMainFrame const):
(WebCore::FocusController::setFocused):
(WebCore::FocusController::setFocusedInternal):
(WebCore::FocusController::relinquishFocusToChrome):
(WebCore::FocusController::advanceFocusInDocumentOrder):
(WebCore::shouldClearSelectionWhenChangingFocusedElement):
(WebCore::FocusController::setFocusedElement):
(WebCore::FocusController::protectedPage const):
(WebCore::FocusController::setActive):
(WebCore::FocusController::setActiveInternal):
(WebCore::FocusController::setIsVisibleAndActiveInternal):
(WebCore::FocusController::advanceFocusDirectionallyInContainer):
* Source/WebCore/page/FocusController.h:
* Source/WebCore/page/LocalDOMWindow.cpp:
(WebCore::LocalDOMWindow::shouldHaveWebKitNamespaceForWorld):
(WebCore::LocalDOMWindow::webkitNamespace):
(WebCore::LocalDOMWindow::isAllowedToUseDeviceMotion const):
(WebCore::LocalDOMWindow::open):
* Source/WebCore/page/LocalFrame.cpp:
(WebCore::LocalFrame::screenSize const):
* Source/WebCore/page/LocalFrameView.cpp:
(WebCore::LocalFrameView::updateSnapOffsets):
* Source/WebCore/page/LocalFrameViewLayoutContext.cpp:
(WebCore::LocalFrameViewLayoutContext::layout):
(WebCore::LocalFrameViewLayoutContext::performLayout):
(WebCore::LocalFrameViewLayoutContext::runPostLayoutTasks):
(WebCore::LocalFrameViewLayoutContext::scheduleLayout):
(WebCore::LocalFrameViewLayoutContext::scheduleSubtreeLayout):
(WebCore::LocalFrameViewLayoutContext::updateStyleForLayout):
(WebCore::LocalFrameViewLayoutContext::protectedFrame):
(WebCore::LocalFrameViewLayoutContext::view const):
(WebCore::LocalFrameViewLayoutContext::protectedView const):
* Source/WebCore/page/LocalFrameViewLayoutContext.h:
* Source/WebCore/page/Location.cpp:
(WebCore::Location::reload):
* Source/WebCore/page/MouseEventWithHitTestResults.h:
(WebCore::MouseEventWithHitTestResults::protectedTargetNode const):
* Source/WebCore/page/Navigator.cpp:
(WebCore::Navigator::appVersion const):
(WebCore::Navigator::userAgent const):
(WebCore::Navigator::plugins):
(WebCore::Navigator::mimeTypes):
(WebCore::Navigator::cookieEnabled const):
* Source/WebCore/page/Page.cpp:
(WebCore::Page::viewportArguments const):
(WebCore::Page::takeAnyMediaCanStartListener):
(WebCore::Page::setCanStartMedia):
(WebCore::Page::protectedMainFrame const):
(WebCore::Page::forEachDocument const):
* Source/WebCore/page/Page.h:
* Source/WebCore/page/PageConsoleClient.cpp:
(WebCore::PageConsoleClient::addMessage):
(WebCore::PageConsoleClient::messageWithTypeAndLevel):
(WebCore::PageConsoleClient::count):
(WebCore::PageConsoleClient::countReset):
(WebCore::PageConsoleClient::profile):
(WebCore::PageConsoleClient::profileEnd):
(WebCore::PageConsoleClient::takeHeapSnapshot):
(WebCore::PageConsoleClient::time):
(WebCore::PageConsoleClient::timeLog):
(WebCore::PageConsoleClient::timeEnd):
(WebCore::PageConsoleClient::timeStamp):
(WebCore::PageConsoleClient::screenshot):
(WebCore::PageConsoleClient::protectedPage const):
* Source/WebCore/page/PageConsoleClient.h:
* Source/WebCore/page/PageOverlayController.cpp:
(WebCore::PageOverlayController::createRootLayersIfNeeded):
(WebCore::PageOverlayController::installedPageOverlaysChanged):
(WebCore::PageOverlayController::protectedPage const):
(WebCore::PageOverlayController::attachViewOverlayLayers):
(WebCore::PageOverlayController::detachViewOverlayLayers):
(WebCore::PageOverlayController::layerWithDocumentOverlays):
(WebCore::PageOverlayController::layerWithViewOverlays):
(WebCore::PageOverlayController::protectedLayerWithViewOverlays):
(WebCore::PageOverlayController::installPageOverlay):
(WebCore::PageOverlayController::updateForceSynchronousScrollLayerPositionUpdates):
(WebCore::PageOverlayController::didChangeViewExposedRect):
(WebCore::PageOverlayController::updateSettingsForLayer):
(WebCore::PageOverlayController::deviceScaleFactor const):
(WebCore::PageOverlayController::notifyFlushRequired):
(WebCore::PageOverlayController::didChangeOverlayFrame):
(WebCore::PageOverlayController::didChangeOverlayBackgroundColor):
(WebCore::PageOverlayController::tiledBackingUsageChanged):
* Source/WebCore/page/PageOverlayController.h:
* Source/WebCore/page/PerformanceMonitor.cpp:
(WebCore::PerformanceMonitor::didFinishLoad):
(WebCore::PerformanceMonitor::activityStateChanged):
(WebCore::PerformanceMonitor::measurePostLoadCPUUsage):
(WebCore::PerformanceMonitor::measurePostLoadMemoryUsage):
(WebCore::PerformanceMonitor::measurePostBackgroundingMemoryUsage):
(WebCore::PerformanceMonitor::measurePostBackgroundingCPUUsage):
(WebCore::PerformanceMonitor::measurePerActivityStateCPUUsage):
(WebCore::PerformanceMonitor::measureCPUUsageInActivityState):
* Source/WebCore/page/PerformanceMonitor.h:
* Source/WebCore/page/PointerLockController.cpp:
(WebCore::PointerLockController::didAcquirePointerLock):
(WebCore::PointerLockController::didNotAcquirePointerLock):
(WebCore::PointerLockController::didLosePointerLock):
(WebCore::PointerLockController::enqueueEvent):
* Source/WebCore/page/Quirks.cpp:
(WebCore::Quirks::needsAutoplayPlayPauseEvents const):
(WebCore::Quirks::needsPerDocumentAutoplayBehavior const):
(WebCore::Quirks::shouldSynthesizeTouchEvents const):
(WebCore::Quirks::shouldBypassBackForwardCache const):
(WebCore::Quirks::shouldAvoidPastingImagesAsWebContent const):
(WebCore::Quirks::requestStorageAccessAndHandleClick const):
(WebCore::Quirks::protectedDocument const):
(WebCore::Quirks::triggerOptionalStorageAccessIframeQuirk const):
(WebCore::Quirks::triggerOptionalStorageAccessQuirk const):
(WebCore::Quirks::needsDisableDOMPasteAccessQuirk const):
* Source/WebCore/page/Quirks.h:
* Source/WebCore/page/ResourceUsageOverlay.cpp:
(WebCore::ResourceUsageOverlay::~ResourceUsageOverlay):
(WebCore::ResourceUsageOverlay::initialize):
(WebCore::ResourceUsageOverlay::mouseEvent):
* Source/WebCore/page/Screen.cpp:
(WebCore::fingerprintingProtectionsEnabled):
(WebCore::Screen::height const):
(WebCore::Screen::width const):
(WebCore::Screen::colorDepth const):
(WebCore::Screen::availLeft const):
(WebCore::Screen::availTop const):
(WebCore::Screen::availHeight const):
(WebCore::Screen::availWidth const):
(WebCore::Screen::orientation):
* Source/WebCore/page/SpatialNavigation.cpp:
(WebCore::FocusCandidate::FocusCandidate):
(WebCore::canScrollInDirection):
(WebCore::nodeRectInAbsoluteCoordinates):
(WebCore::virtualRectForAreaElementAndDirection):
(WebCore::frameOwnerElement):
* Source/WebCore/page/SpatialNavigation.h:
* Source/WebCore/page/WebKitNamespace.cpp:
(WebCore::WebKitNamespace::WebKitNamespace):
* Source/WebCore/page/cocoa/WebTextIndicatorLayer.mm:
(-[WebTextIndicatorLayer present]):
* Source/WebCore/page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::passWidgetMouseDownEventToWidget):
* Source/WebCore/page/mac/ServicesOverlayController.h:
* Source/WebCore/page/mac/ServicesOverlayController.mm:
(WebCore::ServicesOverlayController::invalidateHighlightsOfType):
(WebCore::ServicesOverlayController::buildPotentialHighlightsIfNeeded):
(WebCore::ServicesOverlayController::remainingTimeUntilHighlightShouldBeShown const):
(WebCore::ServicesOverlayController::buildPhoneNumberHighlights):
(WebCore::ServicesOverlayController::buildSelectionHighlight):
(WebCore::ServicesOverlayController::hasRelevantSelectionServices):
(WebCore::ServicesOverlayController::createOverlayIfNeeded):
(WebCore::ServicesOverlayController::telephoneNumberRangesForFocusedFrame):
(WebCore::ServicesOverlayController::findTelephoneNumberHighlightContainingSelectionHighlight):
(WebCore::ServicesOverlayController::mouseEvent):
(WebCore::ServicesOverlayController::handleClick):
* Source/WebCore/rendering/HitTestResult.cpp:
(WebCore::HitTestResult::protectedTargetNode const):
(WebCore::HitTestResult::protectedTargetElement const):
* Source/WebCore/rendering/HitTestResult.h:
* Source/WebCore/rendering/RenderWidget.h:
(WebCore::RenderWidget::protectedWidget const):

Canonical link: https://commits.webkit.org/274488@main




More information about the webkit-changes mailing list