[webkit-changes] [WebKit/WebKit] 4f259d: [threaded-animation-resolution] only set `opacity`...

Antoine Quint noreply at github.com
Mon Feb 12 12:29:24 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4f259dc1446ec3ebd687fe2fc588b56e7b21af4d
      https://github.com/WebKit/WebKit/commit/4f259dc1446ec3ebd687fe2fc588b56e7b21af4d
  Author: Antoine Quint <graouts at webkit.org>
  Date:   2024-02-12 (Mon, 12 Feb 2024)

  Changed paths:
    M Source/WebCore/platform/animation/AcceleratedEffectStack.h
    M Source/WebKit/UIProcess/RemoteLayerTree/RemoteAcceleratedEffectStack.h
    M Source/WebKit/UIProcess/RemoteLayerTree/RemoteAcceleratedEffectStack.mm

  Log Message:
  -----------
  [threaded-animation-resolution] only set `opacity` values if the effect stack requires it
https://bugs.webkit.org/show_bug.cgi?id=269146

Reviewed by Simon Fraser.

We added support for blending the `opacity` property with threaded animation resolution enabled with 274102 at main.
However, we would set the blended opacity regardless of whether the effect stack targets that property. We now
check whether `opacity` is indeed targeted before doing any work to set it.

* Source/WebCore/platform/animation/AcceleratedEffectStack.h:
* Source/WebKit/UIProcess/RemoteLayerTree/RemoteAcceleratedEffectStack.h:
* Source/WebKit/UIProcess/RemoteLayerTree/RemoteAcceleratedEffectStack.mm:
(WebKit::RemoteAcceleratedEffectStack::setEffects):
(WebKit::RemoteAcceleratedEffectStack::initEffectsFromMainThread):
(WebKit::RemoteAcceleratedEffectStack::applyEffectsFromScrollingThread const):
(WebKit::RemoteAcceleratedEffectStack::applyEffectsFromMainThread const):

Canonical link: https://commits.webkit.org/274478@main




More information about the webkit-changes mailing list