[webkit-changes] [WebKit/WebKit] 562393: [WGSL] Validate that resources do not collide

Tadeu Zagallo noreply at github.com
Mon Feb 12 08:29:27 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 56239356040fd44ee197fea5563fb1ed91975efc
      https://github.com/WebKit/WebKit/commit/56239356040fd44ee197fea5563fb1ed91975efc
  Author: Tadeu Zagallo <tzagallo at apple.com>
  Date:   2024-02-12 (Mon, 12 Feb 2024)

  Changed paths:
    M Source/WebGPU/WGSL/GlobalVariableRewriter.cpp

  Log Message:
  -----------
  [WGSL] Validate that resources do not collide
https://bugs.webkit.org/show_bug.cgi?id=269078
rdar://122652489

Reviewed by Mike Wyrzykowski.

The goal was to fix shader,validation,decl,var:binding_collisions:*, but in order
to pass that test this validation needs to during during shader creation time, while
we current run it at pipeline creation time. However, moving the validation requires
a significantly larger change, which will happen later, but this seemed like a
worthwhile validation to have in the meantime.

* Source/WebGPU/WGSL/GlobalVariableRewriter.cpp:
(WGSL::RewriteGlobalVariables::visitEntryPoint):
(WGSL::RewriteGlobalVariables::determineUsedGlobals):

Canonical link: https://commits.webkit.org/274459@main




More information about the webkit-changes mailing list