[webkit-changes] [WebKit/WebKit] 21b659: TextTrack should be constructed with a ScriptExecu...

Jean-Yves Avenard noreply at github.com
Mon Feb 12 01:09:22 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 21b659583b5f8410887b7fada7bf8775ced3f3db
      https://github.com/WebKit/WebKit/commit/21b659583b5f8410887b7fada7bf8775ced3f3db
  Author: Jean-Yves Avenard <jya at apple.com>
  Date:   2024-02-12 (Mon, 12 Feb 2024)

  Changed paths:
    M Source/WebCore/Modules/mediasource/SourceBuffer.cpp
    M Source/WebCore/Modules/mediasource/SourceBuffer.h
    M Source/WebCore/html/HTMLTrackElement.h
    M Source/WebCore/html/track/InbandDataTextTrack.cpp
    M Source/WebCore/html/track/InbandDataTextTrack.h
    M Source/WebCore/html/track/InbandGenericTextTrack.cpp
    M Source/WebCore/html/track/InbandGenericTextTrack.h
    M Source/WebCore/html/track/InbandTextTrack.cpp
    M Source/WebCore/html/track/InbandTextTrack.h
    M Source/WebCore/html/track/InbandWebVTTTextTrack.cpp
    M Source/WebCore/html/track/InbandWebVTTTextTrack.h
    M Source/WebCore/html/track/LoadableTextTrack.cpp
    M Source/WebCore/html/track/TextTrack.cpp
    M Source/WebCore/html/track/TextTrack.h
    M Source/WebCore/html/track/VTTCue.cpp

  Log Message:
  -----------
  TextTrack should be constructed with a ScriptExecutionContext rather than a Document
https://bugs.webkit.org/show_bug.cgi?id=269181
rdar://122776217

Reviewed by Eric Carlson and Ryosuke Niwa.

In order to have MSE in a Worker, we'll need to have {Text/Audio/Video} to be available in DedicatedWorker.

This change just the TextTracks constructors to take a ScriptExecutionContext ; it still requires it
to be a Document for now.

* Source/WebCore/Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveInitializationSegment):
(WebCore::SourceBuffer::document const): Deleted.
* Source/WebCore/Modules/mediasource/SourceBuffer.h:
* Source/WebCore/html/HTMLTrackElement.h:
* Source/WebCore/html/track/InbandDataTextTrack.cpp:
(WebCore::InbandDataTextTrack::InbandDataTextTrack):
(WebCore::InbandDataTextTrack::create):
(WebCore::InbandDataTextTrack::addDataCue):
* Source/WebCore/html/track/InbandDataTextTrack.h:
* Source/WebCore/html/track/InbandGenericTextTrack.cpp:
(WebCore::InbandGenericTextTrack::InbandGenericTextTrack):
(WebCore::InbandGenericTextTrack::create):
(WebCore::InbandGenericTextTrack::addGenericCue):
(WebCore::InbandGenericTextTrack::parser):
(WebCore::InbandGenericTextTrack::newCuesParsed):
* Source/WebCore/html/track/InbandGenericTextTrack.h:
* Source/WebCore/html/track/InbandTextTrack.cpp:
(WebCore::InbandTextTrack::create):
(WebCore::InbandTextTrack::InbandTextTrack):
* Source/WebCore/html/track/InbandTextTrack.h:
* Source/WebCore/html/track/InbandWebVTTTextTrack.cpp:
(WebCore::InbandWebVTTTextTrack::InbandWebVTTTextTrack):
(WebCore::InbandWebVTTTextTrack::create):
(WebCore::InbandWebVTTTextTrack::parser):
(WebCore::InbandWebVTTTextTrack::newCuesParsed):
* Source/WebCore/html/track/InbandWebVTTTextTrack.h:
* Source/WebCore/html/track/LoadableTextTrack.cpp:
(WebCore::LoadableTextTrack::LoadableTextTrack):
* Source/WebCore/html/track/TextTrack.cpp:
(WebCore::TextTrack::create):
(WebCore::TextTrack::document const): Deleted.
* Source/WebCore/html/track/TextTrack.h:
* Source/WebCore/html/track/VTTCue.cpp:
(WebCore::VTTCue::prepareToSpeak):

Canonical link: https://commits.webkit.org/274455@main




More information about the webkit-changes mailing list