[webkit-changes] [WebKit/WebKit] cd3428: ShadowRoot.h shouldn't include HTMLVideoElement.h

Ryosuke Niwa noreply at github.com
Sun Feb 11 15:22:53 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cd3428091d601012e1311c695be3e43437fcd092
      https://github.com/WebKit/WebKit/commit/cd3428091d601012e1311c695be3e43437fcd092
  Author: Ryosuke Niwa <rniwa at webkit.org>
  Date:   2024-02-11 (Sun, 11 Feb 2024)

  Changed paths:
    M Source/WebCore/bindings/js/JSDOMConvertInterface.h
    M Source/WebCore/dom/ShadowRoot.cpp
    M Source/WebCore/dom/ShadowRoot.h

  Log Message:
  -----------
  ShadowRoot.h shouldn't include HTMLVideoElement.h
https://bugs.webkit.org/show_bug.cgi?id=269155

Reviewed by Jean-Yves Avenard.

Remove #include "HTMLVideoElement.h" from ShadowRoot.h.

* Source/WebCore/bindings/js/JSDOMConvertInterface.h:
* Source/WebCore/dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::pictureInPictureElement const): Now returns Element*. Forward declaring
HTMLVideoElement isn't sufficient since DocumentOrShadowRoot+FullScreen.idl requires converting
the return value of this function to Element.
* Source/WebCore/dom/ShadowRoot.h:

Canonical link: https://commits.webkit.org/274450@main




More information about the webkit-changes mailing list