[webkit-changes] [WebKit/WebKit] 739468: Introduce a <model> loading process - Part 3

eddydas noreply at github.com
Fri Feb 9 19:59:03 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 73946828b41b9d2d1cb13e062ed95c4ba85affa6
      https://github.com/WebKit/WebKit/commit/73946828b41b9d2d1cb13e062ed95c4ba85affa6
  Author: Eddy Wong <eddy_wong at apple.com>
  Date:   2024-02-09 (Fri, 09 Feb 2024)

  Changed paths:
    M .gitignore
    A Source/WebKit/Configurations/ModelService.xcconfig
    M Source/WebKit/DerivedSources-input.xcfilelist
    M Source/WebKit/DerivedSources-output.xcfilelist
    M Source/WebKit/DerivedSources.make
    A Source/WebKit/ModelProcess/EntryPoint/Cocoa/XPCService/ModelService/Info-embedded.plist
    A Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Model.sb.in
    M Source/WebKit/Scripts/compile-sandbox.sh
    M Source/WebKit/Scripts/process-entitlements.sh
    M Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeHostIOS.mm
    M Source/WebKit/WebKit.xcodeproj/project.pbxproj
    M Source/WebKit/WebProcess/Model/ModelProcessModelPlayer.mm

  Log Message:
  -----------
  Introduce a <model> loading process - Part 3
https://bugs.webkit.org/show_bug.cgi?id=243874
rdar://122051588 (Create new com.apple.WebKit.Model process)

Reviewed by Elliott Williams.

Added Xcode target for the actual ModelProcess XPC service.
Added sandbox profile (which inherits directly from WebProcess for now).
Actually trigger the launching of the process when <model> tag is present
when the user enables the ModelProcess path.
Stops the existing UIProcess based rendering path when the user enables
ModelProcess path.

* .gitignore:
Removed a rule that doesn't seem to apply to anything recent Xcode generates.
Having it around makes git ignore the model process sandbox profile unexpectedly.

* Source/WebKit/Configurations/ModelService.xcconfig: Added.
* Source/WebKit/DerivedSources-input.xcfilelist:
* Source/WebKit/DerivedSources-output.xcfilelist:
* Source/WebKit/DerivedSources.make:
* Source/WebKit/ModelProcess/EntryPoint/Cocoa/XPCService/ModelService/Info-embedded.plist: Added.
* Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Model.sb.in: Added.
* Source/WebKit/Scripts/compile-sandbox.sh:
* Source/WebKit/Scripts/process-entitlements.sh:
* Source/WebKit/UIProcess/Model/ModelProcessProxy.cpp:
(WebKit::ModelProcessProxy::updateProcessAssertion):
* Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeHostIOS.mm:
(WebKit::RemoteLayerTreeHost::makeNode):
* Source/WebKit/UIProcess/WebContextClient.cpp:
(WebKit::WebContextClient::modelProcessDidCrash): Deleted.
* Source/WebKit/UIProcess/WebContextClient.h:
* Source/WebKit/UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::modelProcessExited):
* Source/WebKit/UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::createModelProcessConnection):
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Source/WebKit/WebProcess/Model/ModelProcessModelPlayer.mm:

Canonical link: https://commits.webkit.org/274408@main




More information about the webkit-changes mailing list