[webkit-changes] [WebKit/WebKit] 5a7f28: Adopt even more smart pointers in WebCore/page

Chris Dumez noreply at github.com
Fri Feb 9 17:15:40 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5a7f28d6380cd44da002dedcbce3f011cbf8a74e
      https://github.com/WebKit/WebKit/commit/5a7f28d6380cd44da002dedcbce3f011cbf8a74e
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2024-02-09 (Fri, 09 Feb 2024)

  Changed paths:
    M Source/WebCore/dom/DeviceMotionController.cpp
    M Source/WebCore/dom/DeviceOrientationController.cpp
    M Source/WebCore/page/DOMSelection.cpp
    M Source/WebCore/page/DOMTimer.cpp
    M Source/WebCore/page/DOMWindowExtension.cpp
    M Source/WebCore/page/DOMWindowExtension.h
    M Source/WebCore/page/DebugPageOverlays.cpp
    M Source/WebCore/page/DebugPageOverlays.h
    M Source/WebCore/page/DeviceClient.h
    M Source/WebCore/page/DeviceController.cpp
    M Source/WebCore/page/DeviceController.h
    M Source/WebCore/page/DragController.cpp
    M Source/WebCore/page/DragController.h
    M Source/WebCore/page/mac/DragControllerMac.mm

  Log Message:
  -----------
  Adopt even more smart pointers in WebCore/page
https://bugs.webkit.org/show_bug.cgi?id=269097

Reviewed by Darin Adler.

* Source/WebCore/dom/DeviceMotionController.cpp:
(WebCore::DeviceMotionController::deviceMotionClient):
* Source/WebCore/dom/DeviceOrientationController.cpp:
(WebCore::DeviceOrientationController::deviceOrientationClient):
* Source/WebCore/page/DOMSelection.cpp:
(WebCore::selectionShadowAncestor):
(WebCore::DOMSelection::range const):
(WebCore::DOMSelection::anchorPosition const):
(WebCore::DOMSelection::focusPosition const):
(WebCore::DOMSelection::basePosition const):
(WebCore::DOMSelection::extentPosition const):
(WebCore::DOMSelection::isCollapsed const):
(WebCore::DOMSelection::type const):
(WebCore::DOMSelection::direction const):
(WebCore::DOMSelection::collapse):
(WebCore::DOMSelection::collapseToEnd):
(WebCore::DOMSelection::collapseToStart):
(WebCore::DOMSelection::setBaseAndExtent):
(WebCore::DOMSelection::modify):
(WebCore::DOMSelection::extend):
(WebCore::createLiveRangeBeforeShadowHostWithSelection):
(WebCore::DOMSelection::getRangeAt):
(WebCore::DOMSelection::removeAllRanges):
(WebCore::DOMSelection::addRange):
(WebCore::DOMSelection::removeRange):
(WebCore::DOMSelection::getComposedRanges):
(WebCore::DOMSelection::deleteFromDocument):
(WebCore::DOMSelection::toString const):
(WebCore::DOMSelection::shadowAdjustedNode const):
(WebCore::DOMSelection::shadowAdjustedOffset const):
(WebCore::DOMSelection::isValidForPosition const):
* Source/WebCore/page/DOMTimer.cpp:
(WebCore::DOMTimer::DOMTimer):
(WebCore::DOMTimer::install):
(WebCore::DOMTimer::removeById):
(WebCore::DOMTimer::updateThrottlingStateIfNecessary):
(WebCore::DOMTimer::fired):
(WebCore::DOMTimer::updateTimerIntervalIfNecessary):
(WebCore::DOMTimer::makeImminentlyScheduledWorkScopeIfPossible):
* Source/WebCore/page/DOMWindowExtension.cpp:
(WebCore::DOMWindowExtension::DOMWindowExtension):
(WebCore::DOMWindowExtension::~DOMWindowExtension):
(WebCore::DOMWindowExtension::protectedFrame const):
(WebCore::DOMWindowExtension::suspendForBackForwardCache):
(WebCore::DOMWindowExtension::resumeFromBackForwardCache):
(WebCore::DOMWindowExtension::willDestroyGlobalObjectInCachedFrame):
(WebCore::DOMWindowExtension::willDestroyGlobalObjectInFrame):
(WebCore::DOMWindowExtension::willDetachGlobalObjectFromFrame):
* Source/WebCore/page/DOMWindowExtension.h:
* Source/WebCore/page/DebugPageOverlays.cpp:
(WebCore::RegionOverlay::protectedOverlay):
(WebCore::RegionOverlay::protectedPage const):
(WebCore::MouseWheelRegionOverlay::updateRegion):
(WebCore::NonFastScrollableRegionOverlay::updateRegion):
(WebCore::InteractionRegionOverlay::activeLayer const):
(WebCore::InteractionRegionOverlay::activeRegion const):
(WebCore::InteractionRegionOverlay::rectForSettingAtIndex const):
(WebCore::InteractionRegionOverlay::mouseEvent):
(WebCore::RegionOverlay::~RegionOverlay):
(WebCore::RegionOverlay::recomputeRegion):
(WebCore::DebugPageOverlays::ensureRegionOverlayForPage):
(WebCore::DebugPageOverlays::hideRegionOverlay):
(WebCore::DebugPageOverlays::regionChanged):
(WebCore::DebugPageOverlays::hasOverlaysForPage const):
(WebCore::DebugPageOverlays::updateRegionIfNecessary):
(WebCore::DebugPageOverlays::regionOverlayForPage const):
(WebCore::DebugPageOverlays::shouldPaintOverlayIntoLayer const):
* Source/WebCore/page/DebugPageOverlays.h:
(WebCore::DebugPageOverlays::hasOverlaysForPage const): Deleted.
* Source/WebCore/page/DeviceClient.h:
* Source/WebCore/page/DeviceController.cpp:
(WebCore::DeviceController::addDeviceEventListener):
(WebCore::DeviceController::removeDeviceEventListener):
(WebCore::DeviceController::removeAllDeviceEventListeners):
(WebCore::DeviceController::client):
(WebCore::DeviceController::fireDeviceEvent):
* Source/WebCore/page/DeviceController.h:
(WebCore::DeviceController::client): Deleted.
* Source/WebCore/page/DragController.cpp:
(WebCore::documentFragmentFromDragData):
(WebCore::DragController::clearDragCaret):
(WebCore::DragController::dragExited):
(WebCore::DragController::performDragOperation):
(WebCore::DragController::mouseMovedIntoDocument):
(WebCore::DragController::dragEnteredOrUpdated):
(WebCore::DragController::protectedPage const):
(WebCore::DragController::tryDocumentDrag):
(WebCore::DragController::operationForLoad):
(WebCore::setSelectionToDragCaret):
(WebCore::DragController::dispatchTextInputEventFor):
(WebCore::DragController::concludeEditDrag):
(WebCore::DragController::canProcessDrag):
(WebCore::DragController::tryDHTMLDrag):
(WebCore::imageElementIsDraggable):
(WebCore::getImage):
(WebCore::selectElement):
(WebCore::DragController::prepareForDragStart const):
(WebCore::DragController::startDrag):
(WebCore::DragController::doImageDrag):
(WebCore::DragController::beginDrag):
(WebCore::DragController::doSystemDrag):
(WebCore::DragController::tryToUpdateDroppedImagePlaceholders):
(WebCore::DragController::insertDroppedImagePlaceholdersAtCaret):
(WebCore::DragController::finalizeDroppedImagePlaceholder):
(WebCore::DragController::placeDragCaret):
* Source/WebCore/page/DragController.h:
* Source/WebCore/page/mac/DragControllerMac.mm:
(WebCore::DragController::cleanupAfterSystemDrag):

Canonical link: https://commits.webkit.org/274404@main




More information about the webkit-changes mailing list