[webkit-changes] [WebKit/WebKit] 06f137: [IFC][Ruby] Text are clipped at the bottom on some...

Alan Baradlay noreply at github.com
Fri Feb 9 14:03:44 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 06f1371ababea8cdce120d1f2c6b4361271435ca
      https://github.com/WebKit/WebKit/commit/06f1371ababea8cdce120d1f2c6b4361271435ca
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-02-09 (Fri, 09 Feb 2024)

  Changed paths:
    A LayoutTests/fast/ruby/ruby-with-unbreakable-characters-incorrect-width-expected.html
    A LayoutTests/fast/ruby/ruby-with-unbreakable-characters-incorrect-width.html
    M Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp

  Log Message:
  -----------
  [IFC][Ruby] Text are clipped at the bottom on some pages with ruby in Books
https://bugs.webkit.org/show_bug.cgi?id=269079
<rdar://122586549>

Reviewed by Antti Koivisto.

Take ruby width adjustment (annotation box is wider than base content) into account when non-trivial line breaking requires us to rebuild the current line.

* LayoutTests/fast/ruby/ruby-with-unbreakable-characters-incorrect-width-expected.html: Added.
* LayoutTests/fast/ruby/ruby-with-unbreakable-characters-incorrect-width.html: Added.
* Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:
(WebCore::Layout::LineBuilder::rebuildLineWithInlineContent): This is the exact copy of what we do in candidateContentForLine when collecting the content for current line.

Canonical link: https://commits.webkit.org/274387@main




More information about the webkit-changes mailing list