[webkit-changes] [WebKit/WebKit] 5a6b8b: PluginView::existingSelectionContainsPoint is an u...

Abrar Rahman Protyasha noreply at github.com
Fri Feb 9 09:42:08 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5a6b8b6df3eec46c5bfb30463bc269055ba933d5
      https://github.com/WebKit/WebKit/commit/5a6b8b6df3eec46c5bfb30463bc269055ba933d5
  Author: Abrar Rahman Protyasha <a_protyasha at apple.com>
  Date:   2024-02-09 (Fri, 09 Feb 2024)

  Changed paths:
    M Source/WebKit/WebProcess/Plugins/PluginView.cpp
    M Source/WebKit/WebProcess/Plugins/PluginView.h

  Log Message:
  -----------
  PluginView::existingSelectionContainsPoint is an unused function
https://bugs.webkit.org/show_bug.cgi?id=269052
rdar://122609786

Reviewed by Sammy Gill.

Nothing is calling into this, so let's remove it.

I've decided to keep PDFPluginBase::existingSelectionContainsPoint since
that has some plugin-internal usage, though it may make more sense to
make it a PDFPlugin-only thing depending on forthcoming changes in this
area.

* Source/WebKit/WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::existingSelectionContainsPoint const): Deleted.
* Source/WebKit/WebProcess/Plugins/PluginView.h:

Canonical link: https://commits.webkit.org/274371@main




More information about the webkit-changes mailing list