[webkit-changes] [WebKit/WebKit] d1a819: Make DOM Range correctly account for CDATASection ...

Anne van Kesteren noreply at github.com
Thu Feb 8 23:24:11 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d1a819848ad3af8938fe1e25d65518383e551dae
      https://github.com/WebKit/WebKit/commit/d1a819848ad3af8938fe1e25d65518383e551dae
  Author: Anne van Kesteren <annevk at annevk.nl>
  Date:   2024-02-08 (Thu, 08 Feb 2024)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/dom/common.js
    M LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Node-compareDocumentPosition-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Node-contains-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Node-properties-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Node-properties.html
    M LayoutTests/imported/w3c/web-platform-tests/dom/ranges/Range-cloneContents-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/dom/ranges/Range-cloneContents.html
    M LayoutTests/imported/w3c/web-platform-tests/dom/ranges/Range-cloneRange-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/dom/ranges/Range-collapse-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/dom/ranges/Range-commonAncestorContainer-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/dom/ranges/Range-compareBoundaryPoints-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/dom/ranges/Range-comparePoint-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/dom/ranges/Range-deleteContents-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/dom/ranges/Range-deleteContents.html
    M LayoutTests/imported/w3c/web-platform-tests/dom/ranges/Range-extractContents-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/dom/ranges/Range-insertNode-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/dom/ranges/Range-intersectsNode-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/dom/ranges/Range-isPointInRange-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/dom/ranges/Range-selectNode-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/dom/ranges/Range-set-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/dom/ranges/Range-surroundContents-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/dom/ranges/Range-surroundContents.html
    M LayoutTests/imported/w3c/web-platform-tests/dom/traversal/NodeIterator-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/dom/traversal/NodeIterator-removal-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/dom/traversal/TreeWalker-expected.txt
    M Source/WebCore/dom/Range.cpp

  Log Message:
  -----------
  Make DOM Range correctly account for CDATASection nodes
https://bugs.webkit.org/show_bug.cgi?id=268903

Reviewed by Ryosuke Niwa.

When the DOM Standard talks about Text nodes it is inclusive of
CDATASection nodes, e.g.,
https://dom.spec.whatwg.org/#concept-range-insert

Test changes are exported via:
https://github.com/web-platform-tests/wpt/pull/44432

* LayoutTests/imported/w3c/web-platform-tests/dom/common.js:
(setupRangeTests):
(nodeLength):
(myExtractContents):
(myInsertNode):
(isText):
(ensurePreInsertionValidity):
* LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Node-compareDocumentPosition-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Node-contains-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Node-properties-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Node-properties.html:
* LayoutTests/imported/w3c/web-platform-tests/dom/ranges/Range-cloneContents-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/dom/ranges/Range-cloneContents.html:
* LayoutTests/imported/w3c/web-platform-tests/dom/ranges/Range-cloneRange-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/dom/ranges/Range-collapse-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/dom/ranges/Range-commonAncestorContainer-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/dom/ranges/Range-compareBoundaryPoints-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/dom/ranges/Range-comparePoint-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/dom/ranges/Range-deleteContents-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/dom/ranges/Range-deleteContents.html:
* LayoutTests/imported/w3c/web-platform-tests/dom/ranges/Range-extractContents-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/dom/ranges/Range-insertNode-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/dom/ranges/Range-intersectsNode-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/dom/ranges/Range-isPointInRange-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/dom/ranges/Range-selectNode-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/dom/ranges/Range-set-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/dom/ranges/Range-surroundContents-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/dom/ranges/Range-surroundContents.html:
* LayoutTests/imported/w3c/web-platform-tests/dom/traversal/NodeIterator-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/dom/traversal/NodeIterator-removal-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/dom/traversal/TreeWalker-expected.txt:
* Source/WebCore/dom/Range.cpp:
(WebCore::Range::insertNode):
(WebCore::Range::surroundContents):

Canonical link: https://commits.webkit.org/274346@main




More information about the webkit-changes mailing list