[webkit-changes] [WebKit/WebKit] bc58f4: Crash when closing DashLane extension popup.

Timothy Hatcher noreply at github.com
Thu Feb 8 21:45:20 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bc58f493f50e6787944a0044979ea5a58b223b9a
      https://github.com/WebKit/WebKit/commit/bc58f493f50e6787944a0044979ea5a58b223b9a
  Author: Timothy Hatcher <timothy at apple.com>
  Date:   2024-02-08 (Thu, 08 Feb 2024)

  Changed paths:
    M Source/WebKit/WebProcess/Extensions/API/WebExtensionAPIPort.h

  Log Message:
  -----------
  Crash when closing DashLane extension popup.
https://webkit.org/b/269041
rdar://problem/122599318

Reviewed by Alex Christensen.

* Source/WebKit/WebProcess/Extensions/API/WebExtensionAPIPort.h:
(WebKit::WebExtensionAPIPort::~WebExtensionAPIPort):
Set m_disconnected to true to prevent the disconnect event from firing.
We can't call into JavaScript during garbage collection.

Canonical link: https://commits.webkit.org/274344@main




More information about the webkit-changes mailing list