[webkit-changes] [WebKit/WebKit] 91ff64: [WebGPU] api, validation, capability_checks, * is fai...

mwyrzykowski noreply at github.com
Thu Feb 8 02:03:54 PST 2024 

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 91ff64157ab79c13a28fad45cdfc3c405c8064ba
      https://github.com/WebKit/WebKit/commit/91ff64157ab79c13a28fad45cdfc3c405c8064ba
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2024-02-08 (Thu, 08 Feb 2024)

  Changed paths:
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/features/query_types-expected.txt
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/features/texture_formats-expected.txt
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/limit_utils.js
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/maxBindGroups-expected.txt
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/maxBindGroups.spec.js
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/maxBindingsPerBindGroup-expected.txt
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/maxColorAttachmentBytesPerSample-expected.txt
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/maxColorAttachments-expected.txt
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/maxComputeWorkgroupSizeX-expected.txt
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/maxComputeWorkgroupSizeY-expected.txt
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/maxComputeWorkgroupSizeZ-expected.txt
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/maxComputeWorkgroupStorageSize-expected.txt
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/maxComputeWorkgroupsPerDimension-expected.txt
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/maxInterStageShaderComponents-expected.txt
    A LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/maxSampledTexturesPerShaderStage-expected.txt
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/maxSampledTexturesPerShaderStage.spec.js
    A LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/maxSamplersPerShaderStage-expected.txt
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/maxSamplersPerShaderStage.spec.js
    A LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/maxStorageBufferBindingSize-expected.txt
    A LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/maxStorageBuffersPerShaderStage-expected.txt
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/maxStorageBuffersPerShaderStage.spec.js
    A LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/maxStorageTexturesPerShaderStage-expected.txt
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/maxStorageTexturesPerShaderStage.spec.js
    A LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/maxTextureArrayLayers-expected.txt
    A LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/maxTextureDimension1D-expected.txt
    A LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/maxTextureDimension2D-expected.txt
    A LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/maxTextureDimension3D-expected.txt
    A LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/maxUniformBufferBindingSize-expected.txt
    A LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/maxUniformBuffersPerShaderStage-expected.txt
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/maxUniformBuffersPerShaderStage.spec.js
    A LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/maxVertexAttributes-expected.txt
    A LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/maxVertexBufferArrayStride-expected.txt
    A LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/maxVertexBuffers-expected.txt
    A LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/minStorageBufferOffsetAlignment-expected.txt
    A LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/minUniformBufferOffsetAlignment-expected.txt
    M Source/WebCore/Modules/WebGPU/GPUCommandEncoder.idl
    M Source/WebCore/Modules/WebGPU/GPUDevice.cpp
    M Source/WebCore/Modules/WebGPU/GPUDevice.h
    M Source/WebCore/Modules/WebGPU/GPUPresentationContext.cpp
    M Source/WebCore/Modules/WebGPU/GPUPresentationContext.h
    M Source/WebCore/Modules/WebGPU/GPUTexture.cpp
    M Source/WebCore/Modules/WebGPU/GPUTexture.h
    M Source/WebCore/Modules/WebGPU/Implementation/WebGPUDeviceImpl.cpp
    M Source/WebCore/Modules/WebGPU/Implementation/WebGPUPresentationContextImpl.cpp
    M Source/WebCore/html/canvas/GPUCanvasContext.h
    M Source/WebCore/html/canvas/GPUCanvasContextCocoa.h
    M Source/WebCore/html/canvas/GPUCanvasContextCocoa.mm
    M Source/WebGPU/WGSL/GlobalVariableRewriter.cpp
    M Source/WebGPU/WGSL/WGSL.h
    M Source/WebGPU/WebGPU/BindGroup.mm
    M Source/WebGPU/WebGPU/BindGroupLayout.mm
    M Source/WebGPU/WebGPU/ComputePipeline.mm
    M Source/WebGPU/WebGPU/Device.h
    M Source/WebGPU/WebGPU/HardwareCapabilities.mm
    M Source/WebGPU/WebGPU/PipelineLayout.mm
    M Source/WebGPU/WebGPU/PresentationContext.h
    M Source/WebGPU/WebGPU/PresentationContextIOSurface.mm
    M Source/WebGPU/WebGPU/Queue.mm
    M Source/WebGPU/WebGPU/RenderBundleEncoder.mm
    M Source/WebGPU/WebGPU/RenderPassEncoder.mm
    M Source/WebGPU/WebGPU/RenderPipeline.mm
    M Source/WebGPU/WebGPU/ShaderModule.h
    M Source/WebGPU/WebGPU/ShaderModule.mm
    M Source/WebGPU/WebGPU/Texture.mm
    M Source/WebGPU/WebGPU/WebGPU.h

  Log Message:
  -----------
  [WebGPU] api,validation,capability_checks,* is failing
https://bugs.webkit.org/show_bug.cgi?id=267283
<radar://120726401>

Reviewed by Tadeu Zagallo.

Add validation and passing expectations for the 33 tests under http/tests/webgpu/webgpu/api/validation/capability_checks

* LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/features/query_types-expected.txt:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/features/query_types.spec.js:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/features/texture_formats-expected.txt:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/features/texture_formats.spec.js:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/limit_utils.js:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/maxBindGroups-expected.txt: Added.
* LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/maxBindGroups.spec.js:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/maxBindingsPerBindGroup-expected.txt: Added.
* LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/maxBindingsPerBindGroup.spec.js:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/maxBufferSize-expected.txt: Added.
* LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/maxBufferSize.spec.js:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/maxColorAttachmentBytesPerSample-expected.txt: Added.
* LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/maxColorAttachmentBytesPerSample.spec.js:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/maxColorAttachments-expected.txt: Added.
* LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/maxColorAttachments.spec.js:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/maxComputeInvocationsPerWorkgroup-expected.txt: Added.
* LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/maxComputeInvocationsPerWorkgroup.spec.js:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/maxComputeWorkgroupSizeX-expected.txt: Added.
* LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/maxComputeWorkgroupSizeX.spec.js:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/maxComputeWorkgroupSizeY-expected.txt: Added.
* LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/maxComputeWorkgroupSizeY.spec.js:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/maxComputeWorkgroupSizeZ-expected.txt: Added.
* LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/maxComputeWorkgroupSizeZ.spec.js:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/maxComputeWorkgroupStorageSize-expected.txt: Added.
* LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/maxComputeWorkgroupStorageSize.spec.js:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/maxComputeWorkgroupsPerDimension-expected.txt: Added.
* LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/maxComputeWorkgroupsPerDimension.spec.js:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/maxDynamicStorageBuffersPerPipelineLayout-expected.txt: Added.
* LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/maxDynamicStorageBuffersPerPipelineLayout.spec.js:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/maxDynamicUniformBuffersPerPipelineLayout-expected.txt: Added.
* LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/maxDynamicUniformBuffersPerPipelineLayout.spec.js:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/maxInterStageShaderComponents-expected.txt: Added.
* LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/maxInterStageShaderComponents.spec.js:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/maxInterStageShaderVariables-expected.txt: Added.
* LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/maxInterStageShaderVariables.spec.js:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/maxSampledTexturesPerShaderStage-expected.txt: Added.
* LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/maxSampledTexturesPerShaderStage.spec.js:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/maxSamplersPerShaderStage-expected.txt: Added.
* LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/maxSamplersPerShaderStage.spec.js:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/maxStorageBufferBindingSize-expected.txt: Added.
* LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/maxStorageBufferBindingSize.spec.js:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/maxStorageBuffersPerShaderStage.spec.js:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/maxStorageTexturesPerShaderStage-expected.txt: Added.
* LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/maxStorageTexturesPerShaderStage.spec.js:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/maxTextureArrayLayers-expected.txt: Added.
* LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/maxTextureArrayLayers.spec.js:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/maxTextureDimension1D-expected.txt: Added.
* LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/maxTextureDimension1D.spec.js:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/maxTextureDimension2D-expected.txt: Added.
* LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/maxTextureDimension2D.spec.js:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/maxTextureDimension3D-expected.txt: Added.
* LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/maxTextureDimension3D.spec.js:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/maxUniformBufferBindingSize-expected.txt: Added.
* LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/maxUniformBufferBindingSize.spec.js:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/maxUniformBuffersPerShaderStage-expected.txt: Added.
* LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/maxUniformBuffersPerShaderStage.spec.js:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/maxVertexAttributes-expected.txt: Added.
* LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/maxVertexAttributes.spec.js:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/maxVertexBufferArrayStride-expected.txt: Added.
* LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/maxVertexBufferArrayStride.spec.js:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/maxVertexBuffers-expected.txt: Added.
* LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/maxVertexBuffers.spec.js:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/minStorageBufferOffsetAlignment-expected.txt: Added.
* LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/minStorageBufferOffsetAlignment.spec.js:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/minUniformBufferOffsetAlignment-expected.txt: Added.
* LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/minUniformBufferOffsetAlignment.spec.js:
* Source/WebCore/Modules/WebGPU/GPUCommandEncoder.idl:
* Source/WebCore/Modules/WebGPU/GPUDevice.cpp:
(WebCore::GPUDevice::isSupportedFormat const):
(WebCore::GPUDevice::createTexture):
(WebCore::GPUDevice::createBindGroupLayout):
(WebCore::GPUDevice::createRenderPipeline):
(WebCore::GPUDevice::createRenderPipelineAsync):
(WebCore::GPUDevice::createRenderBundleEncoder):
(WebCore::GPUDevice::createQuerySet):
* Source/WebCore/Modules/WebGPU/GPUDevice.h:
* Source/WebCore/Modules/WebGPU/GPUPresentationContext.cpp:
(WebCore::GPUPresentationContext::configure):
(WebCore::GPUPresentationContext::getCurrentTexture):
* Source/WebCore/Modules/WebGPU/GPUPresentationContext.h:
* Source/WebCore/Modules/WebGPU/GPUTexture.cpp:
(WebCore::GPUTexture::GPUTexture):
(WebCore::GPUTexture::createView const):
* Source/WebCore/Modules/WebGPU/GPUTexture.h:
(WebCore::GPUTexture::create):
* Source/WebCore/Modules/WebGPU/Implementation/WebGPUPresentationContextImpl.cpp:
(WebCore::WebGPU::PresentationContextImpl::configure):
* Source/WebCore/html/canvas/GPUCanvasContext.h:
* Source/WebCore/html/canvas/GPUCanvasContextCocoa.h:
* Source/WebCore/html/canvas/GPUCanvasContextCocoa.mm:
(WebCore::GPUCanvasContextCocoa::configure):
* Source/WebGPU/WGSL/GlobalVariableRewriter.cpp:
(WGSL::getPrimitiveSize):
(WGSL::getPrimitiveAlignment):
(WGSL::alignmentForVectorSize):
(WGSL::getTypeAlignment):
(WGSL::getStructAlignment):
(WGSL::getTypeSize):
(WGSL::getRoundedSize):
(WGSL::RewriteGlobalVariables::visitEntryPoint):
* Source/WebGPU/WGSL/TypeCheck.cpp:
(WGSL::TypeChecker::visitVariable):
* Source/WebGPU/WGSL/WGSL.h:
* Source/WebGPU/WebGPU/BindGroup.mm:
(WebGPU::Device::createBindGroup):
* Source/WebGPU/WebGPU/BindGroupLayout.mm:
(WebGPU::reportErrorInCreateBindGroupLayout):
(WebGPU::Device::createBindGroupLayout):
* Source/WebGPU/WebGPU/ComputePipeline.mm:
(WebGPU::Device::createComputePipeline):
* Source/WebGPU/WebGPU/Device.h:
* Source/WebGPU/WebGPU/HardwareCapabilities.mm:
(WebGPU::multipleOf4):
(WebGPU::maxBufferSize):
(WebGPU::workaroundCTSBindGroupLimit):
(WebGPU::apple3):
(WebGPU::apple4):
(WebGPU::apple5):
(WebGPU::apple6):
(WebGPU::apple7):
(WebGPU::mac2):
(WebGPU::mergeLimits):
(WebGPU::rawHardwareCapabilities):
(WebGPU::defaultLimits):
* Source/WebGPU/WebGPU/PipelineLayout.mm:
(WebGPU::reportErrorInCreatePipelineLayout):
(WebGPU::Device::createPipelineLayout):
* Source/WebGPU/WebGPU/PresentationContext.h:
* Source/WebGPU/WebGPU/PresentationContextIOSurface.mm:
(WebGPU::PresentationContextIOSurface::configure):
* Source/WebGPU/WebGPU/Queue.mm:
(WebGPU::Queue::commitMTLCommandBuffer):
* Source/WebGPU/WebGPU/RenderBundleEncoder.mm:
(WebGPU::Device::createRenderBundleEncoder):
(WebGPU::RenderBundleEncoder::finish):
* Source/WebGPU/WebGPU/RenderPipeline.mm:
(WebGPU::createVertexDescriptor):
(WebGPU::Device::generatePipelineLayout):
(WebGPU::errorValidatingInterstageShaderInterfaces):
(WebGPU::Device::createRenderPipeline):
* Source/WebGPU/WebGPU/ShaderModule.h:
* Source/WebGPU/WebGPU/ShaderModule.mm:
(WebGPU::ShaderModule::usesFrontFacingInInput const):
(WebGPU::ShaderModule::usesSampleIndexInInput const):
(WebGPU::ShaderModule::usesSampleMaskInInput const):
(WebGPU::ShaderModule::populateFragmentInputs):
(WebGPU::ShaderModule::parseFragmentInputs):
(WebGPU::ShaderModule::fragmentReturnTypeForEntryPoint const):
(WebGPU::populateFragmentInputs): Deleted.
(WebGPU::parseFragmentInputs): Deleted.
* Source/WebGPU/WebGPU/Texture.mm:
(WebGPU::Device::createTexture):
(WebGPU::featureRequirementForFormat): Deleted.
* Source/WebGPU/WebGPU/WebGPU.h:

Canonical link: https://commits.webkit.org/274277@main

More information about the webkit-changes mailing list