[webkit-changes] [WebKit/WebKit] dde576: [Perf Dashboard] AsyncTaskWorker is buggy

[Yusuke Suzuki]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: dde5760b8dbf355dc9e872edd85a14be5a96313c
      https://github.com/WebKit/WebKit/commit/dde5760b8dbf355dc9e872edd85a14be5a96313c
  Author: Yusuke Suzuki <ysuzuki at apple.com>
  Date:   2024-02-07 (Wed, 07 Feb 2024)

  Changed paths:
    M PerformanceTests/JetStream2/worker/async-task.js
    M PerformanceTests/JetStream2/worker/segmentation.js
    M Websites/perf.webkit.org/public/v3/async-task.js

  Log Message:
  -----------
  [Perf Dashboard] AsyncTaskWorker is buggy
https://bugs.webkit.org/show_bug.cgi?id=268962
rdar://121879117

Reviewed by Ryosuke Niwa.

There are two issues.

1. Even we found a worker and calling a callback, we are still pushing it into the queue. This makes scheduling this callback twice.
2. In setTimeout's task, we are not checking length of the _queue. This may be zero since existing workers are continuously consuming tasks.
   So we should first check the length before popping the task from that.

* PerformanceTests/JetStream2/worker/async-task.js:
(AsyncTaskWorker.waitForAvailableWorker):
(AsyncTaskWorker._makeWorkerEventuallyAvailable):
* PerformanceTests/JetStream2/worker/segmentation.js:
(AsyncTaskWorker.waitForAvailableWorker):
(AsyncTaskWorker._makeWorkerEventuallyAvailable):
* Websites/perf.webkit.org/public/v3/async-task.js:
(AsyncTaskWorker.waitForAvailableWorker):
(AsyncTaskWorker._makeWorkerEventuallyAvailable):

Canonical link: https://commits.webkit.org/274265@main