[webkit-changes] [WebKit/WebKit] bb2f1a: [WebGPU] api, validation, image_copy, * is failing

mwyrzykowski noreply at github.com
Wed Feb 7 16:55:47 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bb2f1af0dcabcb924f3c4a294a3d40f11a586ed1
      https://github.com/WebKit/WebKit/commit/bb2f1af0dcabcb924f3c4a294a3d40f11a586ed1
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2024-02-07 (Wed, 07 Feb 2024)

  Changed paths:
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/image_copy/buffer_related-expected.txt
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/image_copy/buffer_texture_copies-expected.txt
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/image_copy/layout_related-expected.txt
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/image_copy/texture_related-expected.txt
    M Source/WebCore/Modules/WebGPU/Implementation/WebGPUQueueImpl.cpp
    M Source/WebGPU/WebGPU/CommandEncoder.h
    M Source/WebGPU/WebGPU/CommandEncoder.mm
    M Source/WebGPU/WebGPU/Queue.h
    M Source/WebGPU/WebGPU/Queue.mm
    M Source/WebGPU/WebGPU/Texture.h
    M Source/WebGPU/WebGPU/Texture.mm

  Log Message:
  -----------
  [WebGPU] api,validation,image_copy,* is failing
https://bugs.webkit.org/show_bug.cgi?id=267284
<radar://120726665>

Reviewed by Dan Glastonbury.

Add validation for image_copy tests along with passing expectations.

* LayoutTests/http/tests/webgpu/webgpu/api/validation/image_copy/buffer_related-expected.txt:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/image_copy/buffer_texture_copies-expected.txt:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/image_copy/layout_related-expected.txt:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/image_copy/texture_related-expected.txt:
* Source/WebCore/Modules/WebGPU/Implementation/WebGPUQueueImpl.cpp:
(WebCore::WebGPU::QueueImpl::writeTexture):
* Source/WebGPU/WebGPU/CommandEncoder.h:
* Source/WebGPU/WebGPU/CommandEncoder.mm:
(WebGPU::CommandEncoder::errorValidatingImageCopyBuffer const):
(WebGPU::CommandEncoder::errorValidatingCopyBufferToTexture const):
(WebGPU::CommandEncoder::copyBufferToTexture):
(WebGPU::CommandEncoder::errorValidatingCopyTextureToBuffer const):
(WebGPU::CommandEncoder::copyTextureToBuffer):
(WebGPU::validateCopyTextureToTexture):
(WebGPU::validateImageCopyBuffer): Deleted.
(WebGPU::validateCopyBufferToTexture): Deleted.
(WebGPU::validateCopyTextureToBuffer): Deleted.
* Source/WebGPU/WebGPU/Queue.h:
* Source/WebGPU/WebGPU/Queue.mm:
(WebGPU::Queue::writeBuffer):
(WebGPU::Queue::errorValidatingWriteTexture const):
(WebGPU::Queue::clearTexture):
(WebGPU::Queue::writeTexture):
(WebGPU::validateWriteTexture): Deleted.
* Source/WebGPU/WebGPU/Texture.h:
* Source/WebGPU/WebGPU/Texture.mm:
(WebGPU::Texture::logicalMiplevelSpecificTextureExtent):
(WebGPU::Texture::physicalMiplevelSpecificTextureExtent):
(WebGPU::Texture::errorValidatingImageCopyTexture):
(WebGPU::Texture::validateLinearTextureData):
(WebGPU::Texture::validateImageCopyTexture): Deleted.

Canonical link: https://commits.webkit.org/274257@main




More information about the webkit-changes mailing list