[webkit-changes] [WebKit/WebKit] bbdeb4: Log MarketplaceKit errors to JavaScript console
bnham
noreply at github.com
Wed Feb 7 15:03:09 PST 2024
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: bbdeb4c175f1f442d9e9708d34cc18fa57c1455b
https://github.com/WebKit/WebKit/commit/bbdeb4c175f1f442d9e9708d34cc18fa57c1455b
Author: Ben Nham <nham at apple.com>
Date: 2024-02-07 (Wed, 07 Feb 2024)
Changed paths:
M Source/WebKit/UIProcess/Cocoa/NavigationState.mm
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/UIProcess/WebPageProxy.h
M Source/WebKit/WebKitSwift/MarketplaceKit/MarketplaceKitWrapper.swift
Log Message:
-----------
Log MarketplaceKit errors to JavaScript console
https://bugs.webkit.org/show_bug.cgi?id=268936
rdar://122488574
Reviewed by Brent Fulgham.
Currently if a user taps on a MarketplaceKit link and the installation fails, we log the error to
the device console. We should also log the error to the JS console as well to make errors easier to
debug for developers.
* Source/WebKit/UIProcess/Cocoa/NavigationState.mm:
(WebKit::interceptMarketplaceKitNavigation):
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::addConsoleMessage):
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/WebKitSwift/MarketplaceKit/MarketplaceKitWrapper.swift:
(MarketplaceKitWrapper.requestAppInstallation(_:url:completionHandler:)):
(MarketplaceKitWrapper.requestAppInstallation(_:url:)): Deleted.
Canonical link: https://commits.webkit.org/274247@main
More information about the webkit-changes
mailing list