[webkit-changes] [WebKit/WebKit] 200045: [WGSL] shader, validation, decl, var:* is failing
Tadeu Zagallo
noreply at github.com
Wed Feb 7 13:24:32 PST 2024
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 200045f29c1b7ecf425cd1dc954c85689ac7f163
https://github.com/WebKit/WebKit/commit/200045f29c1b7ecf425cd1dc954c85689ac7f163
Author: Tadeu Zagallo <tzagallo at apple.com>
Date: 2024-02-07 (Wed, 07 Feb 2024)
Changed paths:
M Source/WebGPU/WGSL/TypeCheck.cpp
M Source/WebGPU/WGSL/Types.cpp
M Source/WebGPU/WGSL/Types.h
Log Message:
-----------
[WGSL] shader,validation,decl,var:* is failing
https://bugs.webkit.org/show_bug.cgi?id=268878
rdar://122436149
Reviewed by Mike Wyrzykowski.
Validate the type of variable declarations according to the spec rules[1] based
on the address space and access mode.
[1]: https://www.w3.org/TR/WGSL/#var-and-value
* Source/WebGPU/WGSL/TypeCheck.cpp:
(WGSL::TypeChecker::visitVariable):
* Source/WebGPU/WGSL/Types.cpp:
(WGSL::Type::isStorable const):
(WGSL::Type::isHostShareable const):
(WGSL::Type::hasFixedFootprint const):
* Source/WebGPU/WGSL/Types.h:
Canonical link: https://commits.webkit.org/274243@main
More information about the webkit-changes
mailing list