[webkit-changes] [WebKit/WebKit] 87a427: [WebGPU] SharedVideoFrameWriter::write may crash i...

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 87a42742787370324e01274cffe4761d5e09a14d
      https://github.com/WebKit/WebKit/commit/87a42742787370324e01274cffe4761d5e09a14d
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2024-02-07 (Wed, 07 Feb 2024)

  Changed paths:
    M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteDevice.cpp
    M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteDeviceProxy.cpp

  Log Message:
  -----------
  [WebGPU] SharedVideoFrameWriter::write may crash if frame is invalid
https://bugs.webkit.org/show_bug.cgi?id=268846
<radar://122399334>

Reviewed by Tadeu Zagallo.

Two issues were present, first there was a release assert on a pointer
to a RefPtr and not its value and second it is not guaranteed that
mediaIdentifier has a value when there is no sharedVideoFrame.

* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteDevice.cpp:
(WebKit::RemoteDevice::importExternalTextureFromVideoFrame):
* Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteDeviceProxy.cpp:
(WebKit::WebGPU::RemoteDeviceProxy::importExternalTexture):

Canonical link: https://commits.webkit.org/274238@main