[webkit-changes] [WebKit/WebKit] c3d587: Update RenderText::text() to return a String inste...

Chris Dumez noreply at github.com
Wed Feb 7 10:01:44 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c3d587ae821634418180e6c9f88bc159723f458e
      https://github.com/WebKit/WebKit/commit/c3d587ae821634418180e6c9f88bc159723f458e
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2024-02-07 (Wed, 07 Feb 2024)

  Changed paths:
    M Source/WebCore/editing/TextIterator.cpp
    M Source/WebCore/layout/integration/LayoutIntegrationBoxTree.cpp
    M Source/WebCore/rendering/RenderText.h

  Log Message:
  -----------
  Update RenderText::text() to return a String instead of a StringImpl
https://bugs.webkit.org/show_bug.cgi?id=268918

Reviewed by Alan Baradlay.

Update RenderText::text() to return a String instead of a StringImpl. It is safe
 to deal with Strings than with StringImpl pointers directly. There is also zero
 performance difference on Speedometer 2 & 3.

* Source/WebCore/editing/TextIterator.cpp:
(WebCore::collapsedSpaceLength):
* Source/WebCore/layout/integration/LayoutIntegrationBoxTree.cpp:
(WebCore::LayoutIntegration::BoxTree::createLayoutBox):
(WebCore::LayoutIntegration::BoxTree::updateContent):
* Source/WebCore/rendering/RenderText.h:
(WebCore::RenderText::text const):

Canonical link: https://commits.webkit.org/274220@main




More information about the webkit-changes mailing list