[webkit-changes] [WebKit/WebKit] d89784: After branching on node type use uncheckedDowncast<>

Anne van Kesteren noreply at github.com
Wed Feb 7 03:42:05 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d8978483a98776f1e51225731fcb8d74c62d605a
      https://github.com/WebKit/WebKit/commit/d8978483a98776f1e51225731fcb8d74c62d605a
  Author: Anne van Kesteren <annevk at annevk.nl>
  Date:   2024-02-07 (Wed, 07 Feb 2024)

  Changed paths:
    M Source/WebCore/dom/Range.cpp
    M Source/WebCore/editing/MarkupAccumulator.cpp
    M Source/WebCore/editing/MarkupAccumulator.h

  Log Message:
  -----------
  After branching on node type use uncheckedDowncast<>
https://bugs.webkit.org/show_bug.cgi?id=268751

Reviewed by Chris Dumez.

We can use the riskier uncheckedDowncast<> when it is clear the type is
correct, as it is in these switch statements.

* Source/WebCore/dom/Range.cpp:
(WebCore::processContentsBetweenOffsets):
(WebCore::Range::checkNodeOffsetPair):
* Source/WebCore/editing/MarkupAccumulator.cpp:
(WebCore::MarkupAccumulator::appendNonElementNode):
* Source/WebCore/editing/MarkupAccumulator.h:
(WebCore::MarkupAccumulator::endAppendingNode):

Adopt dynamicDowncast<> while here.

Canonical link: https://commits.webkit.org/274207@main




More information about the webkit-changes mailing list