[webkit-changes] [WebKit/WebKit] 59e2ed: Remove FlattenedConstraints

youennf noreply at github.com
Wed Feb 7 01:33:51 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 59e2ed56406e4f89e2011b3e51f0cec271c6241a
      https://github.com/WebKit/WebKit/commit/59e2ed56406e4f89e2011b3e51f0cec271c6241a
  Author: Youenn Fablet <youennf at gmail.com>
  Date:   2024-02-07 (Wed, 07 Feb 2024)

  Changed paths:
    M Source/WebCore/platform/mediastream/MediaConstraints.cpp
    M Source/WebCore/platform/mediastream/MediaConstraints.h
    M Source/WebCore/platform/mediastream/RealtimeMediaSource.cpp
    M Source/WebCore/platform/mediastream/RealtimeMediaSource.h

  Log Message:
  -----------
  Remove FlattenedConstraints
https://bugs.webkit.org/show_bug.cgi?id=268813
rdar://122375936

Reviewed by Eric Carlson.

FlattenedConstraints can be replaced by MediaTrackConstraintSetMap which has the benefit of being typed.

* Source/WebCore/platform/mediastream/MediaConstraints.cpp:
(WebCore::MediaTrackConstraintSetMap::set):
(WebCore::MediaTrackConstraintSetMap::merge):
(WebCore::FlattenedConstraint::set): Deleted.
(WebCore::FlattenedConstraint::merge): Deleted.
(WebCore::FlattenedConstraint::append): Deleted.
(WebCore::FlattenedConstraint::find const): Deleted.
* Source/WebCore/platform/mediastream/MediaConstraints.h:
(WebCore::MediaTrackConstraintSetMap::width const):
(WebCore::MediaTrackConstraintSetMap::height const):
(WebCore::MediaTrackConstraintSetMap::sampleRate const):
(WebCore::MediaTrackConstraintSetMap::sampleSize const):
(WebCore::MediaTrackConstraintSetMap::aspectRatio const):
(WebCore::MediaTrackConstraintSetMap::frameRate const):
(WebCore::MediaTrackConstraintSetMap::volume const):
(WebCore::MediaTrackConstraintSetMap::echoCancellation const):
(WebCore::MediaTrackConstraintSetMap::displaySurface const):
(WebCore::MediaTrackConstraintSetMap::logicalSurface const):
(WebCore::MediaTrackConstraintSetMap::facingMode const):
(WebCore::MediaTrackConstraintSetMap::deviceId const):
(WebCore::MediaTrackConstraintSetMap::groupId const):
(WebCore::MediaTrackConstraintSetMap::whiteBalanceMode const):
(WebCore::MediaTrackConstraintSetMap::zoom const):
(WebCore::MediaTrackConstraintSetMap::torch const):
(WebCore::FlattenedConstraint::isEmpty const): Deleted.
(WebCore::FlattenedConstraint::iterator::iterator): Deleted.
(WebCore::FlattenedConstraint::iterator::operator* const): Deleted.
(WebCore::FlattenedConstraint::iterator::operator++): Deleted.
(WebCore::FlattenedConstraint::iterator::operator== const): Deleted.
(WebCore::FlattenedConstraint::begin const): Deleted.
(WebCore::FlattenedConstraint::end const): Deleted.
(WebCore::FlattenedConstraint::ConstraintHolder::create): Deleted.
(WebCore::FlattenedConstraint::ConstraintHolder::~ConstraintHolder): Deleted.
(WebCore::FlattenedConstraint::ConstraintHolder::ConstraintHolder): Deleted.
(WebCore::FlattenedConstraint::ConstraintHolder::constraint const): Deleted.
(WebCore::FlattenedConstraint::ConstraintHolder::dataType const): Deleted.
(WebCore::FlattenedConstraint::ConstraintHolder::constraintType const): Deleted.
* Source/WebCore/platform/mediastream/RealtimeMediaSource.cpp:
(WebCore::RealtimeMediaSource::selectSettings):
(WebCore::RealtimeMediaSource::supportsConstraints):
(WebCore::RealtimeMediaSource::extractVideoFrameSizeConstraints):
(WebCore::RealtimeMediaSource::applyConstraints):
* Source/WebCore/platform/mediastream/RealtimeMediaSource.h:

Canonical link: https://commits.webkit.org/274204@main




More information about the webkit-changes mailing list