[webkit-changes] [WebKit/WebKit] 47d90d: [JSC][armv7] Fix crashes in wasm tests in CallFram...

jjgriego noreply at github.com
Tue Feb 6 20:13:12 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 47d90d73bf82af1dc02357be03cd1ad1b2895a22
      https://github.com/WebKit/WebKit/commit/47d90d73bf82af1dc02357be03cd1ad1b2895a22
  Author: Joseph Griego <jgriego at igalia.com>
  Date:   2024-02-06 (Tue, 06 Feb 2024)

  Changed paths:
    M Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp

  Log Message:
  -----------
  [JSC][armv7] Fix crashes in wasm tests in CallFrameShuffler
https://bugs.webkit.org/show_bug.cgi?id=268828

Reviewed by Yusuke Suzuki.

A number of (especially wasm) tests are failing after
https://github.com/WebKit/WebKit/pull/23620, with an assertion in
`CallFrameShuffler::emitStore`.

We just need to use `UnboxedInt32InGPR` instead of `InGPR` for the pointer
registers that need to be preserved when preparing for a tail call, since the
32-bit CallFrameShuffler doesn't know how to deal with `InGPR`.

* Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::emitCall):

Canonical link: https://commits.webkit.org/274195@main




More information about the webkit-changes mailing list