[webkit-changes] [WebKit/WebKit] 46ace4: [ews-build.webkit.org] Allow S3 uploads to declare...

Jonathan Bedard noreply at github.com
Tue Feb 6 11:42:20 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 46ace4312fd53dbc1730b5598ffd84bfb3ac112d
      https://github.com/WebKit/WebKit/commit/46ace4312fd53dbc1730b5598ffd84bfb3ac112d
  Author: Jonathan Bedard <jbedard at apple.com>
  Date:   2024-02-06 (Tue, 06 Feb 2024)

  Changed paths:
    M Tools/CISupport/Shared/generate-s3-url
    M Tools/CISupport/ews-build/steps.py
    M Tools/CISupport/ews-build/steps_unittest.py

  Log Message:
  -----------
  [ews-build.webkit.org] Allow S3 uploads to declare content type
https://bugs.webkit.org/show_bug.cgi?id=268844
rdar://122405197

Reviewed by Aakash Jain.

* Tools/CISupport/Shared/generate-s3-url:
(generateS3URL): Allow caller to specify file extension and content type.
(main): Accept --extension and --content-type arguments.
* Tools/CISupport/ews-build/steps.py:
(UploadFileToS3.__init__): Allow caller to specify content type to upload with.
(UploadFileToS3.run): Ditto.
(GenerateS3URL.__init__): Allow caller to specify extension and content type of file.
(GenerateS3URL.run): Use specified file extension.
* Tools/CISupport/ews-build/steps_unittest.py:
(TestGenerateS3URL.configureStep):
(TestGenerateS3URL.test_failure_with_extension):
(TestUploadFileToS3.configureStep):
(TestUploadFileToS3.test_success_content_type):

Canonical link: https://commits.webkit.org/274163@main




More information about the webkit-changes mailing list