[webkit-changes] [WebKit/WebKit] 6ada69: Crash at WebKit::WebExtensionContext::extensionCan...

[kiaraarose]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6ada695111e8b3664c6753ea67002fe0281ff813
      https://github.com/WebKit/WebKit/commit/6ada695111e8b3664c6753ea67002fe0281ff813
  Author: Kiara Rose <kiara_rose at apple.com>
  Date:   2024-02-06 (Tue, 06 Feb 2024)

  Changed paths:
    M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm

  Log Message:
  -----------
  Crash at WebKit::WebExtensionContext::extensionCanAccessWebPage
https://bugs.webkit.org/show_bug.cgi?id=268837
rdar://122396440

Reviewed by Brian Weinstein.

As seen in https://webkit.org/b/268767, it's likely that the page is being deallocated
and closed by the time the callback for storage is called and so the tab for the page is
not found. Instead of calling the RELEASE_ASSERT_NOT_REACHED() if the extension doesn't
have access to the tab, return false and just log an error.

Add an ASSERT_NOT_REACHED() so we can at least keep track of how often this case is hit.

* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm:
(WebKit::WebExtensionContext::extensionCanAccessWebPage):

Canonical link: https://commits.webkit.org/274161@main