[webkit-changes] [WebKit/WebKit] 1e17d8: [Site Isolation][Mac] Find text indicator is incor...
Charlie Wolfe
noreply at github.com
Tue Feb 6 09:19:22 PST 2024
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 1e17d8281dbd98fe0d906bb12df22219321485ee
https://github.com/WebKit/WebKit/commit/1e17d8281dbd98fe0d906bb12df22219321485ee
Author: Charlie Wolfe <charliew at apple.com>
Date: 2024-02-06 (Tue, 06 Feb 2024)
Changed paths:
M LayoutTests/ipc/set-text-indicator.html
M Source/WebKit/UIProcess/WebFrameProxy.cpp
M Source/WebKit/UIProcess/WebFrameProxy.h
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/UIProcess/WebPageProxy.h
M Source/WebKit/UIProcess/WebPageProxy.messages.in
M Source/WebKit/WebProcess/WebPage/FindController.cpp
M Source/WebKit/WebProcess/WebPage/WebPage.cpp
M Source/WebKit/WebProcess/WebPage/WebPage.h
M Source/WebKit/WebProcess/WebPage/WebPage.messages.in
Log Message:
-----------
[Site Isolation][Mac] Find text indicator is incorrectly offset
https://bugs.webkit.org/show_bug.cgi?id=268760
rdar://121979834
Reviewed by Alex Christensen.
To convert to root view coordinates from a match found in a subframe process we need to convert from
the parent of each root frame.
* Source/WebKit/UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::rootFrame):
* Source/WebKit/UIProcess/WebFrameProxy.h:
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setTextIndicatorFromFrame):
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/UIProcess/WebPageProxy.messages.in:
* Source/WebKit/WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::updateFindIndicator):
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setTextIndicator):
(WebKit::WebPage::remoteViewCoordinatesToRootView):
* Source/WebKit/WebProcess/WebPage/WebPage.h:
* Source/WebKit/WebProcess/WebPage/WebPage.messages.in:
Canonical link: https://commits.webkit.org/274148@main
More information about the webkit-changes
mailing list