[webkit-changes] [WebKit/WebKit] 48c8f1: [GStreamer] Potential dangling pipeline pointer us...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 48c8f103137941a9b9829778fe480226392dd571
      https://github.com/WebKit/WebKit/commit/48c8f103137941a9b9829778fe480226392dd571
  Author: Philippe Normand <philn at igalia.com>
  Date:   2024-02-06 (Tue, 06 Feb 2024)

  Changed paths:
    M Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp

  Log Message:
  -----------
  [GStreamer] Potential dangling pipeline pointer usage in connectSimpleBusMessageCallback
https://bugs.webkit.org/show_bug.cgi?id=268747

Reviewed by Xabier Rodriguez-Calvar.

There was no guarantee the raw pipeline pointer passed as user-data to the signal would remain
valid. So we now pass a custom structure pointer that has the same lifetime as the signal handler.

* Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp:
(WebCore::disconnectSimpleBusMessageCallback):
(WebCore::connectSimpleBusMessageCallback):
(WebCore::CustomMessageHandlerHolder::CustomMessageHandlerHolder): Deleted.

Canonical link: https://commits.webkit.org/274139@main