[webkit-changes] [WebKit/WebKit] 57ded7: [threaded-animation-resolution] initEffectsFromScr...
Antoine Quint
noreply at github.com
Mon Feb 5 23:26:54 PST 2024
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 57ded7c8d22ad9a5ff25d2c2aecce63d9118d966
https://github.com/WebKit/WebKit/commit/57ded7c8d22ad9a5ff25d2c2aecce63d9118d966
Author: Antoine Quint <graouts at webkit.org>
Date: 2024-02-05 (Mon, 05 Feb 2024)
Changed paths:
M Source/WebKit/UIProcess/RemoteLayerTree/RemoteAcceleratedEffectStack.h
M Source/WebKit/UIProcess/RemoteLayerTree/RemoteAcceleratedEffectStack.mm
M Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeNode.mm
Log Message:
-----------
[threaded-animation-resolution] initEffectsFromScrollingThread should be called initEffectsFromMainThread on RemoteAcceleratedEffectStack
https://bugs.webkit.org/show_bug.cgi?id=268803
rdar://122365275
Reviewed by Simon Fraser.
When blending for `opacity` values was added in 274102 at main, the `RemoteAcceleratedEffectStack::initEffectsFromMainThread()`
method was renamed to `initEffectsFromScrollingThread(). This was an error since presentation modifiers are indeed installed
on the main thread, and merely updated on the scrolling thread.
* Source/WebKit/UIProcess/RemoteLayerTree/RemoteAcceleratedEffectStack.h:
* Source/WebKit/UIProcess/RemoteLayerTree/RemoteAcceleratedEffectStack.mm:
(WebKit::RemoteAcceleratedEffectStack::initEffectsFromMainThread):
(WebKit::RemoteAcceleratedEffectStack::initEffectsFromScrollingThread): Deleted.
* Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeNode.mm:
(WebKit::RemoteLayerTreeNode::setAcceleratedEffectsAndBaseValues):
Canonical link: https://commits.webkit.org/274134@main
More information about the webkit-changes
mailing list