[webkit-changes] [WebKit/WebKit] 153d8b: [WebXR] Enable implicit clear for WebXROpaqueFrame...
Dan Glastonbury
noreply at github.com
Mon Feb 5 16:23:27 PST 2024
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 153d8bbf64370ede7b39c06f77ee8183ec993ee2
https://github.com/WebKit/WebKit/commit/153d8bbf64370ede7b39c06f77ee8183ec993ee2
Author: Dan Glastonbury <djg at apple.com>
Date: 2024-02-05 (Mon, 05 Feb 2024)
Changed paths:
M Source/WebCore/Modules/webxr/WebXROpaqueFramebuffer.cpp
M Source/WebCore/html/canvas/WebGLRenderingContextBase.h
M Source/WebCore/html/canvas/WebGLUtilities.h
Log Message:
-----------
[WebXR] Enable implicit clear for WebXROpaqueFramebuffer
https://bugs.webkit.org/show_bug.cgi?id=268042
rdar://117090654
Reviewed by Kimmo Kinnunen.
WebGL's default framebuffer has an implicit clear behavior. The WebXR
specification requires the same behavior for its WebXROpaqueFramebuffer,
therefore WebXR must ensure that it's buffers are always cleared for each rAF of
the session.
Currently we assume content does not do redundant initial clear, as the spec
says the buffer always starts cleared.
* Source/WebCore/Modules/webxr/WebXROpaqueFramebuffer.cpp:
(WebCore::WebXROpaqueFramebuffer::startFrame):
(WebCore::WebXROpaqueFramebuffer::setupFramebuffer):
* Source/WebCore/html/canvas/WebGLRenderingContextBase.h:
* Source/WebCore/html/canvas/WebGLUtilities.h:
(WebCore::ScopedClearColorAndMask::ScopedClearColorAndMask):
(WebCore::ScopedClearColorAndMask::~ScopedClearColorAndMask):
(WebCore::ScopedClearDepthAndMask::ScopedClearDepthAndMask):
(WebCore::ScopedClearDepthAndMask::~ScopedClearDepthAndMask):
(WebCore::ScopedClearStencilAndMask::ScopedClearStencilAndMask):
(WebCore::ScopedClearStencilAndMask::~ScopedClearStencilAndMask):
Canonical link: https://commits.webkit.org/274121@main
More information about the webkit-changes
mailing list