[webkit-changes] [WebKit/WebKit] b3b714: [ews-build.webkit.org] Provide links to S3 uploads

Jonathan Bedard noreply at github.com
Mon Feb 5 13:08:43 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b3b7144bd152111660f81e9aecb76b0a4a8642ab
      https://github.com/WebKit/WebKit/commit/b3b7144bd152111660f81e9aecb76b0a4a8642ab
  Author: Jonathan Bedard <jbedard at apple.com>
  Date:   2024-02-05 (Mon, 05 Feb 2024)

  Changed paths:
    M Tools/CISupport/ews-build/steps.py
    M Tools/CISupport/ews-build/steps_unittest.py

  Log Message:
  -----------
  [ews-build.webkit.org] Provide links to S3 uploads
https://bugs.webkit.org/show_bug.cgi?id=268666
rdar://122208350

Reviewed by Aakash Jain.

Have UploadFileToS3 annotate a previous step with a link to the uploaded archive.

* Tools/CISupport/ews-build/steps.py:
(CompileWebKit.evaluateCommand): Pass link information to UploadFileToS3.
(UploadFileToS3.__init__): Parameterize file path and link construction.
(UploadFileToS3.getLastBuildStepByName):
(UploadFileToS3.run): If upload is successful, extract archive link written by GenerateS3URL
and add a link to a previous step.
(GenerateS3URL.__init__): Parmeterize S3 identifier.
(GenerateS3URL.run): Compute URL of uploaded archive and save for GenerateS3URL.
* Tools/CISupport/ews-build/steps_unittest.py:
(TestGenerateS3URL.configureStep):
(TestGenerateS3URL.test_failure):
(TestUploadFileToS3.configureStep):

Canonical link: https://commits.webkit.org/274111@main




More information about the webkit-changes mailing list