[webkit-changes] [WebKit/WebKit] ed8a54: Adopt RefAllowingPartiallyDestroyed in more places

Chris Dumez noreply at github.com
Sun Feb 4 09:10:04 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ed8a5425873739e1dc5ed9cdda5976f5c94d4684
      https://github.com/WebKit/WebKit/commit/ed8a5425873739e1dc5ed9cdda5976f5c94d4684
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2024-02-04 (Sun, 04 Feb 2024)

  Changed paths:
    M Source/WebCore/dom/Attr.cpp
    M Source/WebCore/dom/CharacterData.cpp
    M Source/WebCore/dom/ContainerNode.cpp
    M Source/WebCore/dom/ContainerNodeAlgorithms.cpp
    M Source/WebCore/dom/Document.cpp
    M Source/WebCore/dom/ShadowRoot.cpp

  Log Message:
  -----------
  Adopt RefAllowingPartiallyDestroyed in more places
https://bugs.webkit.org/show_bug.cgi?id=268709

Reviewed by Ryosuke Niwa.

Adopt RefAllowingPartiallyDestroyed in more places, to further reduce the use
of raw pointers.

This tested as performance neutral on Speedometer 2 & 3.

* Source/WebCore/dom/Attr.cpp:
(WebCore::Attr::detachFromElementWithValue):
* Source/WebCore/dom/CharacterData.cpp:
(WebCore::CharacterData::~CharacterData):
* Source/WebCore/dom/ContainerNode.cpp:
(WebCore::ContainerNode::removeAllChildrenWithScriptAssertion):
(WebCore::ContainerNode::removeNodeWithScriptAssertion):
(WebCore::ContainerNode::~ContainerNode):
(WebCore::ContainerNode::removeBetween):
(WebCore::ContainerNode::rebuildSVGExtensionsElementsIfNecessary):
(WebCore::ContainerNode::childrenChanged):
(WebCore::dispatchChildRemovalEvents):
* Source/WebCore/dom/ContainerNodeAlgorithms.cpp:
(WebCore::removeDetachedChildrenInContainer):
* Source/WebCore/dom/Document.cpp:
(WebCore::Document::wheelEventHandlersChanged):
* Source/WebCore/dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::removedFromAncestor):

Canonical link: https://commits.webkit.org/274070@main




More information about the webkit-changes mailing list