[webkit-changes] [WebKit/WebKit] 1a2dfd: [UnifiedPDF] UnifiedPDFPlugin should handle the "s...

Abrar Rahman Protyasha noreply at github.com
Sat Feb 3 16:41:02 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1a2dfd4eb52baf164e5bab30cf957e0596812571
      https://github.com/WebKit/WebKit/commit/1a2dfd4eb52baf164e5bab30cf957e0596812571
  Author: Abrar Rahman Protyasha <a_protyasha at apple.com>
  Date:   2024-02-03 (Sat, 03 Feb 2024)

  Changed paths:
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm

  Log Message:
  -----------
  [UnifiedPDF] UnifiedPDFPlugin should handle the "selectAll" editing command
https://bugs.webkit.org/show_bug.cgi?id=268689
rdar://122230652

Reviewed by Simon Fraser.

Following the added support for selection tracking in 274032 at main, it is
trivial for the UnifiedPDFPlugin to handle the "selectAll" editing
command.

The plugin does so by simply querying PDFDocument for a selection
representing text for the entire document, and then overriding the
currently tracked selection.

* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h:
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::handleKeyboardEvent):
(WebKit::UnifiedPDFPlugin::handleEditingCommand):
(WebKit::UnifiedPDFPlugin::isEditingCommandEnabled):
(WebKit::UnifiedPDFPlugin::forwardEditingCommandToEditor const):
(WebKit::UnifiedPDFPlugin::selectAll):

Canonical link: https://commits.webkit.org/274056@main




More information about the webkit-changes mailing list