[webkit-changes] [WebKit/WebKit] 71e4e7: [UnifiedPDF] Drive-by style fixes under WebKit/Web...

Abrar Rahman Protyasha noreply at github.com
Sat Feb 3 15:39:38 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 71e4e7e3844641aa59c978c77f47d0ebe4b7785a
      https://github.com/WebKit/WebKit/commit/71e4e7e3844641aa59c978c77f47d0ebe4b7785a
  Author: Abrar Rahman Protyasha <a_protyasha at apple.com>
  Date:   2024-02-03 (Sat, 03 Feb 2024)

  Changed paths:
    M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.mm
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm

  Log Message:
  -----------
  [UnifiedPDF] Drive-by style fixes under WebKit/WebProcess/Plugins/PDF
https://bugs.webkit.org/show_bug.cgi?id=268688
rdar://122230060

Reviewed by Wenson Hsieh.

Namely, we prefer `[retainPtr method:]` over `[retainPtr.get() method:]`,
but also, move an annotation to avoid unnecessary ref-churn when calling
UnifiedPDFPlugin::setActiveAnnotation.

* Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.mm:
(WebKit::PDFPluginBase::maybeClearHighLatencyDataProviderFlag):
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::handleMouseEvent):
(WebKit::UnifiedPDFPlugin::continueTrackingSelection):
(WebKit::UnifiedPDFPlugin::boundsForAnnotation const):

Canonical link: https://commits.webkit.org/274052@main




More information about the webkit-changes mailing list