[webkit-changes] [WebKit/WebKit] 1b40ca: [Painting] text-underline-position left/right beha...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1b40ca37b3ff23bf483289e78d10b74c62a3ca11
      https://github.com/WebKit/WebKit/commit/1b40ca37b3ff23bf483289e78d10b74c62a3ca11
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-02-03 (Sat, 03 Feb 2024)

  Changed paths:
    M Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp
    M Source/WebCore/style/InlineTextBoxStyle.cpp
    M Source/WebCore/style/InlineTextBoxStyle.h

  Log Message:
  -----------
  [Painting] text-underline-position left/right behave as under
https://bugs.webkit.org/show_bug.cgi?id=268691

Reviewed by Antti Koivisto.

This is in preparation for adding text-underline left/right painting support.

1. Replace resolvedUnderlinePosition with isAlignedForUnder (<- spec term)
text-underline-position left/right behave as 'under' in vertical writing mode (also check against current writing mode instead of baseline type)

2. Use isAlignedForUnder() to figure out whether we are dealing with 'under' type of offsetting.

Canonical link: https://commits.webkit.org/274049@main