[webkit-changes] [WebKit/WebKit] d37336: Add a delegate method to let clients opt out of gr...
Brian Weinstein
noreply at github.com
Fri Feb 2 15:22:12 PST 2024
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: d3733674e19a6b2a0f181736faefa896f3223a2d
https://github.com/WebKit/WebKit/commit/d3733674e19a6b2a0f181736faefa896f3223a2d
Author: Brian Weinstein <bweinstein at apple.com>
Date: 2024-02-02 (Fri, 02 Feb 2024)
Changed paths:
M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionTab.h
M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm
M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionTabCocoa.mm
M Source/WebKit/UIProcess/Extensions/WebExtensionTab.h
Log Message:
-----------
Add a delegate method to let clients opt out of granting activeTab from a user gesture
https://bugs.webkit.org/show_bug.cgi?id=268652
rdar://122129916
Reviewed by Timothy Hatcher.
This PR also fixes a place where checking the permission state wasn't exactly correct.
* Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionTab.h:
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm:
(WebKit::WebExtensionContext::permissionState):
(WebKit::WebExtensionContext::userGesturePerformed):
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionTabCocoa.mm:
(WebKit::WebExtensionTab::WebExtensionTab):
(WebKit::WebExtensionTab::shouldGrantTabPermissionsOnUserGesture const):
* Source/WebKit/UIProcess/Extensions/WebExtensionTab.h:
Canonical link: https://commits.webkit.org/274021@main
More information about the webkit-changes
mailing list